Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/prometheus/client_golang from 1.18.0 to 1.19.0 #1784

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 4, 2024

Bumps github.com/prometheus/client_golang from 1.18.0 to 1.19.0.

Release notes

Sourced from github.com/prometheus/client_golang's releases.

v1.19.0

What's Changed

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See prometheus/client_golang#1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #1445 #1449
  • [FEATURE] collectors: Add version collector. #1422 #1427

New Contributors

Full Changelog: prometheus/client_golang@v1.18.0...v1.19.0

Changelog

Sourced from github.com/prometheus/client_golang's changelog.

1.19.0 / 2023-02-27

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See prometheus/client_golang#1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #1445 #1449
  • [FEATURE] collectors: Add version collector. #1422 #1427
Commits
  • 77d4003 Add 1.19.0 changelog (#1451)
  • 14259fa Merge pull request #1448 from ywwg/owilliams/content-negotiation
  • 6d03920 deps: bump prometheus/common version
  • 353395b Remove support for go 1.19 (#1449)
  • 9dd5d2a Merge pull request #1445 from kavu/add_go122_metrics_test
  • c906a5e Add support for Go 1.22
  • 7ac9036 Merge pull request #1440 from prometheus/dependabot/github_actions/github-act...
  • 8c7e30f Merge pull request #1441 from prometheus/dependabot/go_modules/tutorial/whats...
  • 08769f8 Bump github.com/prometheus/common in /tutorial/whatsup
  • 83d5940 Bump the github-actions group with 2 updates
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 4, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 4, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 4, 2024
Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 38a7d93
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65ef76c2839e4f000850d2b4
😎 Deploy Preview https://deploy-preview-1784--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.0 branch from c29e96f to 28cefde Compare March 4, 2024 10:30
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.0 branch from 28cefde to 33a1bfd Compare March 11, 2024 12:00
@tenzen-y
Copy link
Member

/hold
/assign

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.18.0 to 1.19.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.18.0...v1.19.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/prometheus/client_golang-1.19.0 branch from 33a1bfd to 38a7d93 Compare March 11, 2024 21:25
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please ask for approval from tenzen-y. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-unit-main 33a1bfd link true /test pull-kueue-test-unit-main
pull-kueue-test-integration-main 38a7d93 link true /test pull-kueue-test-integration-main
pull-kueue-test-e2e-main-1-27 38a7d93 link true /test pull-kueue-test-e2e-main-1-27
pull-kueue-test-e2e-main-1-26 38a7d93 link true /test pull-kueue-test-e2e-main-1-26
pull-kueue-test-e2e-main-1-28 38a7d93 link true /test pull-kueue-test-e2e-main-1-28
pull-kueue-build-image-main 38a7d93 link true /test pull-kueue-build-image-main
pull-kueue-test-e2e-main-1-29 38a7d93 link true /test pull-kueue-test-e2e-main-1-29
pull-kueue-verify-main 38a7d93 link true /test pull-kueue-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tenzen-y
Copy link
Member

/close
I'll address this issue.

@k8s-ci-robot
Copy link
Contributor

@tenzen-y: Closed this PR.

In response to this:

/close
I'll address this issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 11, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/prometheus/client_golang-1.19.0 branch March 11, 2024 21:32
@tenzen-y
Copy link
Member

I found that we can not update Prometheus client version since there is a breaking change in Prometheus side, and then the k8s.io/component-base depends on the broken feature: prometheus/common#576

@tenzen-y
Copy link
Member

@tenzen-y
Copy link
Member

I found the PR to update the Prometheus client, but the contributor seems to have left the PR.

kubernetes/kubernetes#123547

@alculquicondor
Copy link
Contributor

what about this kubernetes/kubernetes#123547 (comment) ?

@tenzen-y
Copy link
Member

what about this kubernetes/kubernetes#123547 (comment) ?

Actually, kubernetes/kubernetes#124346 resolved the root cause, but the PR was not cherry picked into previous versions :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants