chore: Move VersionCollector to collectors directory #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurSens
force-pushed
the
move-versioncollector
branch
from
d7cbb71
to
bd1d5af
Compare
|
I don't think this package belongs in the collectors directory because the primary use case of this package is to provide a structured version information. The version metric is an extra feature, not the primary feature. Honestly, I think we were wrong in moving this to client_golang. The version information package probably makes more sense in exporter-toolkit. |
|
As a counter-proposal, we could keep In order to do this, I've opened prometheus/common#563 to make the helper function public. |
ArthurSens
force-pushed
the
move-versioncollector
branch
from
bd1d5af
to
8a3bec2
Compare
|
I've changed the PR to continue using prometheus/common, but still depends on prometheus/common#565 |
ArthurSens
force-pushed
the
move-versioncollector
branch
3 times, most recently
from
c1fb44d
to
7cce798
Compare
… code. Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
ArthurSens
force-pushed
the
move-versioncollector
branch
from
7cce798
to
7cf8416
Compare
|
💪🏽 |
|
Nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the newly added Version Collector to the collectors' directory. It's being kept in a separate package because, as @SuperQ mentioned, it uses
init()to collect some information. We don't want to do that unless it is explicit to importersI also added an example in a separate commit, happy to move it to a separate PR if that's preferred.