🌱 Make IPAddressClaim.Status.AddressRef optional

[christianang]

What this PR does / why we need it:

This PR makes the addressRef on the IPAddressClaim status optional. This allows us to set the condition on the IPAddressClaim status without setting the addressRef in the case of failure to allocate an IPAddress.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
This is related to #8424.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: christianang / name: Christian Ang (6020bb4)

[k8s-ci-robot]

Welcome @christianang!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @christianang. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

/ok-to-test

[srm09]

@killianmuldoon can this improvement be backported to the 1.4 release as well?

[schrej]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 5955bca3941dac7bf5c36b64ee54abcc9ccbbb97

[killianmuldoon]

/lgtm

@srm09 For me yes - this is an experimental API type so changes like this are definitely inside CAPI's backporting policy - https://cluster-api.sigs.k8s.io/contributing#backporting-a-patch

[schrej]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 6078d21cac7fef6eeb3531ebc796ee406c24cee4

[fabriziopandini]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

I think backporting is fine. This is pretty much a bugfix to me

Optional vs. Required
Status fields MUST be optional. Our controllers are patching selected fields instead of updating the entire status in every reconciliation.
https://github.com/sbueringer/cluster-api/blob/main/CONTRIBUTING.md#api-conventions

[sbueringer]

/cherry-pick release-1.4

[sbueringer]

/cherry-pick release-1.3

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #8530

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #8531

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[johannesfrey]

/area ipam