Skip to content

Commit

Permalink
Make IPAddressClaim.Status.AddressRef optional
Browse files Browse the repository at this point in the history
to be able to set conditions on the claim without setting the
addressRef, in the case of failure.

Signed-off-by: Christian Ang <angc@vmware.com>
  • Loading branch information
christianang committed Apr 11, 2023
1 parent 4f60841 commit ad1c23d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 0 additions & 2 deletions config/crd/bases/ipam.cluster.x-k8s.io_ipaddressclaims.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion exp/ipam/api/v1alpha1/ipaddressclaim_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ type IPAddressClaimSpec struct {
// IPAddressClaimStatus is the observed status of a IPAddressClaim.
type IPAddressClaimStatus struct {
// AddressRef is a reference to the address that was created for this claim.
AddressRef corev1.LocalObjectReference `json:"addressRef"`
// +optional
AddressRef corev1.LocalObjectReference `json:"addressRef,omitempty"`

// Conditions summarises the current state of the IPAddressClaim
// +optional
Expand Down

0 comments on commit ad1c23d

Please sign in to comment.