New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.13] make ServiceCIDR independent in ManagedPools #4549
[release-1.13] make ServiceCIDR independent in ManagedPools #4549
Conversation
- Service CIDR addition to AKS Cluster should be independent of DNS Service IP - add unit test for Service CIDR change
/cc @kubernetes-sigs/cluster-api-provider-azure-pms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: eb87ed54f24cf1aa0aae5ed47303f787df5973a3
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR is asking for my review, hence |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.13 #4549 +/- ##
=============================================
Coverage 62.10% 62.10%
=============================================
Files 189 189
Lines 18626 18626
=============================================
Hits 11568 11568
Misses 6421 6421
Partials 637 637 ☔ View full report in Codecov by Sentry. |
This is an automated cherry-pick of #4503
/assign nawazkh