Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.13] make ServiceCIDR independent in ManagedPools #4549

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #4503

/assign nawazkh

Service CIDR addition to AKS Cluster should be independent of DNS Service IP

- Service CIDR addition to AKS Cluster should be independent of DNS Service IP
- add unit test for Service CIDR change
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 7, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 7, 2024
@nawazkh
Copy link
Member

nawazkh commented Feb 7, 2024

/cc @kubernetes-sigs/cluster-api-provider-azure-pms

@k8s-ci-robot k8s-ci-robot requested a review from a team February 7, 2024 21:06
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eb87ed54f24cf1aa0aae5ed47303f787df5973a3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
@nawazkh
Copy link
Member

nawazkh commented Feb 7, 2024

PR is asking for my review, hence
/lgtm

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92d4590) 62.10% compared to head (daffc8b) 62.10%.
Report is 1 commits behind head on release-1.13.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.13    #4549   +/-   ##
=============================================
  Coverage         62.10%   62.10%           
=============================================
  Files               189      189           
  Lines             18626    18626           
=============================================
  Hits              11568    11568           
  Misses             6421     6421           
  Partials            637      637           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot merged commit 739b0f2 into kubernetes-sigs:release-1.13 Feb 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants