make ServiceCIDR independent in ManagedPools

[nawazkh]

What type of PR is this?
/kind bug

What this PR does / why we need it:

• Service CIDR should be set independent of DNS Service IP.
• This was originally identified by vishu2498, all credits to vishu2498!

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Replaces PR #3760 since it has become stale and the user seems to be unresponsive.

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Service CIDR addition to AKS Cluster should be independent of DNS Service IP

[nawazkh]

/cc vishu2498

[nawazkh]

Probing AKS REST API, I do not see a reason to set ServiceCIDR only when a DNSServiceIP is set(as of existing implementation in main).
Hence this change.
Reference documentation: https://learn.microsoft.com/en-us/rest/api/aks/managed-clusters/create-or-update?view=rest-aks-2023-10-01&tabs=HTTP#containerservicenetworkprofile

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa75a53) 62.44% compared to head (a8b8b5c) 62.44%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4503   +/-   ##
=======================================
  Coverage   62.44%   62.44%           
=======================================
  Files         192      192           
  Lines       15379    15379           
=======================================
  Hits         9604     9604           
  Misses       5115     5115           
  Partials      660      660           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nawazkh]

I may be able to push changes to original PR by the author, preserving credit to their effort. I will try that.
/hold

[nawazkh]

Tried pushing changes to authors original PR, but couldn't.

❯ git push vishu2498 HEAD:service-cidr-fix
ERROR: Permission to vishu2498/cluster-api-provider-azure.git denied to nawazkh.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I will close the author's original PR.
/unhold

[nawazkh]

I was able to cherry-pick the author's changes! :)

[jackfrancis]

I think we want to update the TestParameters UT to validate the changed conditional flows here.

[jackfrancis]

ping @nawazkh on the UT, I think this PR is basically ready w/ some test coverage

[nawazkh]

ping @nawazkh on the UT, I think this PR is basically ready w/ some test coverage

Thanks for the reminder, updated the PR.

[jackfrancis]

/lgtm

/assign @mboersma @nojnhuh @willie-yao @Jont828

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: ed0ed75e2ab59f1e0e40c519bcc531ba225ccde8

[mboersma]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nawazkh]

/cherry-pick release-1.13

[nawazkh]

/cherry-pick release-1.12

[k8s-infra-cherrypick-robot]

@nawazkh: new pull request created: #4549

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@nawazkh: new pull request created: #4550

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.