Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #15440 on branch 4.0.x (Fix Shift + L not working in stdin) #15451

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Backport PR #15440 on branch 4.0.x (Fix Shift + L not working in stdin) #15451

merged 1 commit into from
Nov 29, 2023

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Nov 28, 2023 •
edited

Backport PR #15440

The users may need to reset the keyboard shortcut fo the fix to be applied - related issue #15326

@jupyterlab-probot jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added the bug label Nov 28, 2023
@fcollonval fcollonval added this to the 4.0.x milestone Nov 28, 2023
@fcollonval fcollonval marked this pull request as ready for review November 28, 2023 15:01
krassowski
krassowski approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the backport! I agree, while users who changed the shortcut will still be affected the benefits outweigh the cons

@krassowski krassowski merged commit 338df29 into jupyterlab:4.0.x Nov 29, 2023
75 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski approved these changes

Assignees

@fcollonval fcollonval

Labels
bug pkg:notebook tag:Testing
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fcollonval @krassowski