Fix failing `check_links` job #14243

krassowski · 2023-03-21T13:57:55Z

References

As seen in #14238 and other PRs check_links job fails with:

docs/source/extension/documents.rst (second attempt)...

F                                                                        [100%]
=================================== FAILURES ===================================
_ /home/runner/work/jupyterlab/jupyterlab/docs/source/extension/documents.rst: https://jupyter-ydoc.readthedocs.io/en/latest/api/classes/YDocument.html _
https://jupyter-ydoc.readthedocs.io/en/latest/api/classes/YDocument.html: 404: Not Found
=============================== warnings summary ===============================
../../../../../opt/hostedtoolcache/Python/3.10.10/x64/lib/python3.10/site-packages/requests_cache/backends/base.py:324
  /opt/hostedtoolcache/Python/3.10.10/x64/lib/python3.10/site-packages/requests_cache/backends/base.py:324: DeprecationWarning: BaseCache.remove_expired_responses() is deprecated; please use .delete(expired=True) instead
    warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED docs/source/extension/documents.rst::/home/runner/work/jupyterlab/jupyterlab/docs/source/extension/documents.rst <a href=https://jupyter-ydoc.readthedocs.io/en/latest/api/classes/YDocument.html>
1 failed, 10 deselected, 1 warning in 0.32s

Code changes

Replace https://jupyter-ydoc.readthedocs.io/en/latest/api/classes/YDocument.html with https://jupyter-ydoc.readthedocs.io/en/latest/api/classes/YDocument-1.html

User-facing changes

None

Backwards-incompatible changes

None

jupyterlab-probot · 2023-03-21T13:57:58Z

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

jtpio · 2023-03-21T17:52:26Z

Thanks @krassowski 👍

Looks like the last run of the check_links was still cancelled though?

krassowski · 2023-03-21T18:28:01Z

Yes, no idea why. It only shows Error: The operation was canceled. but there is no reason given. This was happening for some time, restarting the job after certain time helps.

krassowski · 2023-03-21T21:50:38Z

And it passed after re-triggering 🤷

andrii-i

LGTM, fixes CI fails on master: Linux Tests / check_links (pull_request) fails because there is a dead link in source/extension/documents.rst at line 42 #14248

The problem is still there and needs fixing as far as I can say (please see #14248). Based on what I see now Linux Tests / check_links (pull_request) fails on master because there is a dead link in YDocument https://jupyter-ydoc.readthedocs.io/en/latest/api/classes/YDocument.html string in source/extension/documents.rst at line 42.

Note that in the last commit on master CI is red because of different test (Linux (release_test, 3.11)) and links were not tested, also note that in the commit before that links were tested and step failed. Also see PR #14205 where link test fails for the same reason.

github-actions · 2023-03-22T00:11:45Z

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table

Test file	large_code_notebook	large_md_notebook
open
`chromium`
actual	522 <- [586 - 616 - 659] -> 778	776 <- [1208 - 1249 - 1301] -> 1512
expected	512 <- [573 - 590 - 621] -> 819	1065 <- [1206 - 1235 - 1274] -> 1393
Mean relative change	2.9% ± 2.5%	1.7% ± 1.8%
switch-from
`chromium`
actual	560 <- [662 - 681 - 702] -> 758	304 <- [364 - 405 - 435] -> 535
expected	575 <- [668 - 685 - 711] -> 822	307 <- [348 - 370 - 402] -> 503
Mean relative change	-1.5% ± 1.6%	8.3% ± 3.4%
switch-to
`chromium`
actual	1120 <- [1197 - 1218 - 1254] -> 1410	793 <- [833 - 858 - 908] -> 1028
expected	1135 <- [1189 - 1223 - 1258] -> 1470	769 <- [818 - 838 - 856] -> 963
Mean relative change	-0.3% ± 1.4%	3.8% ± 1.5%
close
`chromium`
actual	141 <- [150 - 157 - 164] -> 189	200 <- [212 - 226 - 248] -> 309
expected	141 <- [149 - 153 - 160] -> 195	198 <- [214 - 222 - 232] -> 282
Mean relative change	1.3% ± 2.0%	3.6% ± 2.6%

Changes are computed with expected as reference.

@jupyterlab/benchmarks@1.0.0 test:mocha
mocha ./tests/

Waiting for localhost:8888
localhost:8888 is up

Cell memory leaks

Create a code cell

Memory change: -160 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
ArraySearchMarker	1	+5 B
ContentDeleted	1	+16 B
ContentString	1	+66 B
Detached Text	1	+72 B
FocusTracker	1	+276 B
ObservableList	1	+172 B
OutputArea	1	+1.43 kB
OutputAreaModel	1	+183 B
Promise	1	+20 B
PromiseDelegate	1	+128 B
ResizeHandle	1	+47 B
RestorablePool	1	+558 B
UndoManager	1	+1.93 kB
WidgetTracker	1	+1.05 kB
YArray	1	+164 B
YCodeCell	1	+107 B
YText	1	+1.23 kB
Detached DOMStringMap	2	+88 B
Detached V8EventHandlerNonNull	2	+80 B
Set	2	+1.42 kB
YMap	2	+464 B
StackItem	3	+1.32 kB
ContentAny	4	+202 B
ContentType	4	+64 B
DeleteItem	4	+80 B
DeleteSet	6	+988 B
Detached HTMLCollection	6	+560 B
EventHandler	8	+256 B
ID	10	+320 B
Item	10	+1.16 kB
Detached DOMTokenList	13	+836 B
Detached Attr	14	+1.01 kB
Detached HTMLDivElement	14	+46.7 kB
Map	17	+11.1 kB
Signal	19	+319 B
Array	44	+25.4 kB
Detached V8EventListener	263	+23.4 kB
Detached EventListener	265	+42.6 kB
(closure)	270	+5.5 kB
Detached InternalNode	323	+45.1 kB

Leaking collections:

Type

Change

Preview

Size increased at

Array

+2

[StackItem, ...]

UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5

Array

+10

[Item, ...]

addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7

Set

+1

Set((anonymous function), ...)

                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                                                                     
Doc.on                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11                                         
new UndoManager           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14                                         
YCodeCell.setUndoManager  http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 
<unknown>                 http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15
Array.forEach             <anonymous>                                                                                                                                    
YNotebook.insertCells     http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16
YNotebook.insertCell      http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22

Create a markdown cell

Memory change: -132 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
ActivityMonitor	1	+294 B
ArraySearchMarker	1	+5 B
AttachmentsModel	1	+193 B
AttachmentsResolver	1	+14 B
CodeCellModel	1	+359 B
ContentString	1	+75 B
Debouncer	1	+3.46 kB
Detached HTMLAnchorElement	1	+300 B
Detached HTMLButtonElement	1	+5.3 kB
Detached HTMLHeadingElement	1	+956 B
Error	1	+3.06 kB
MarkdownCell	1	+4.72 kB
MarkdownCellModel	1	+237 B
Poll	1	+3.7 kB
RenderMimeRegistry	1	+227 B
RenderedMarkdown	1	+66 B
Transaction	1	+860 B
TypeError	1	+301 B
YArray	1	+164 B
YArrayEvent	1	+357 B
YCodeCell	1	+107 B
YMarkdownCell	1	+45 B
Detached CSSStyleDeclaration	2	+120 B
Detached HTMLElement	2	+304 B
Detached V8EventHandlerNonNull	2	+5.04 kB
Promise	2	+3.06 kB
PromiseDelegate	2	+3.27 kB
UndoManager	2	+2.38 kB
YText	2	+484 B
Detached DOMStringMap	3	+132 B
ObservableMap	3	+381 B
StackItem	3	+1.33 kB
DeleteItem	4	+80 B
YMap	4	+872 B
ContentAny	5	+490 B
DeleteSet	6	+1 kB
ContentType	7	+112 B
Detached Text	7	+476 B
Set	8	+1.76 kB
Detached HTMLDivElement	10	+30.4 kB
Detached DOMTokenList	13	+824 B
ID	13	+416 B
Item	13	+1.76 kB
EventHandler	14	+453 B
Detached HTMLCollection	17	+1.76 kB
Map	27	+12.1 kB
Signal	28	+722 B
Detached V8EventListener	130	+10.9 kB
Detached EventListener	132	+25.5 kB
(closure)	152	+-634 B
Detached InternalNode	162	+28.2 kB

Leaking collections:

Type	Change	Preview	Size increased at
Array	+1	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17 Signal.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24 webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37 invokeSlot http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17 Signal.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17 webpack://jupyterlab/packages/notebook/src/widget.ts:1321:30 webpack://jupyterlab/packages/notebook/src/actions.tsx:408:28 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2719:15
Array	+1	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17 Signal.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24 webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33 invokeSlot http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17 Signal.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17 webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30 invokeSlot http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Array	+1	[b7604344-18ec-444f-b231-5cd312c04f54, ...]	webpack://jupyterlab/packages/notebook/src/actions.tsx:2503:37 Array.forEach <anonymous> webpack://jupyterlab/packages/notebook/src/actions.tsx:2498:21 webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2650:15 CommandRegistry.execute http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5748:33 CommandRegistry._executeKeyBinding http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5906:14 CommandRegistry.processKeydownEvent http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5846:18 JupyterLab.evtKeydown http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:4660:23
Array	+2	[StackItem, ...]	UndoManager.afterTransactionHandler http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15 webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.forEach <anonymous> webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.<anonymous> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27 webpack://jupyterlab/node_modules/lib0/function.js:19:0 cleanupTransactions http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9 Doc.transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array	+13	[Item, ...]	addStruct http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11 Item.integrate http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22 Array.forEach <anonymous> typeListInsertGenericsAfter http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11 typeListInsertGenerics http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14 YArray.insert http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set	+2	Set((anonymous function), ...)	webpack://jupyterlab/node_modules/lib0/observable.js:30:56 Doc.on http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11 new UndoManager http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14 YCodeCell.setUndoManager http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 <unknown> http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15 Array.forEach <anonymous> YNotebook.insertCells http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16 YNotebook.insertCell http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21 webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22

Create a raw cell

Memory change: -181 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
ArraySearchMarker	1	+5 B
CodeCellModel	1	+359 B
ContentString	1	+690 B
Detached CSSStyleDeclaration	1	+60 B
Detached V8EventHandlerNonNull	1	+40 B
ObservableMap	1	+109 B
TypeError	1	+301 B
YArray	1	+164 B
YCodeCell	1	+107 B
YRawCell	1	+45 B
Detached DOMStringMap	2	+96 B
Set	2	+1.31 kB
UndoManager	2	+2.38 kB
YText	2	+721 B
StackItem	3	+1.33 kB
DeleteItem	4	+80 B
YMap	4	+872 B
ContentAny	5	+417 B
Detached HTMLCollection	5	+472 B
DeleteSet	6	+1 kB
ContentType	7	+112 B
Detached DOMTokenList	9	+580 B
Detached HTMLDivElement	9	+22.6 kB
Signal	11	+450 B
ID	13	+416 B
Item	13	+2.3 kB
EventHandler	14	+448 B
Map	19	+11.4 kB
Detached V8EventListener	130	+10.9 kB
Detached EventListener	131	+20.4 kB
(closure)	140	+-3.54 kB
Detached InternalNode	151	+21.6 kB

Leaking collections:

Type	Change	Preview	Size increased at
Array	+1	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17 Signal.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24 webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37 invokeSlot http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17 Signal.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17 webpack://jupyterlab/packages/notebook/src/widget.ts:1321:30 webpack://jupyterlab/packages/notebook/src/actions.tsx:408:28 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2719:15
Array	+1	[56356028-9308-4c4a-915e-72e7024bbd0f, ...]	webpack://jupyterlab/packages/notebook/src/actions.tsx:2503:37 Array.forEach <anonymous> webpack://jupyterlab/packages/notebook/src/actions.tsx:2498:21 webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2650:15 CommandRegistry.execute http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5748:33 CommandRegistry._executeKeyBinding http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5906:14 CommandRegistry.processKeydownEvent http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5846:18 JupyterLab.evtKeydown http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:4660:23
Array	+1	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17 Signal.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24 webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33 invokeSlot http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17 Signal.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17 webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30 invokeSlot http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Array	+2	[StackItem, ...]	UndoManager.afterTransactionHandler http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15 webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.forEach <anonymous> webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.<anonymous> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27 webpack://jupyterlab/node_modules/lib0/function.js:19:0 cleanupTransactions http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9 Doc.transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array	+13	[Item, ...]	addStruct http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11 Item.integrate http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22 Array.forEach <anonymous> typeListInsertGenericsAfter http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11 typeListInsertGenerics http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14 YArray.insert http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set	+2	Set((anonymous function), ...)	webpack://jupyterlab/node_modules/lib0/observable.js:30:56 Doc.on http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11 new UndoManager http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14 YCodeCell.setUndoManager http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 <unknown> http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15 Array.forEach <anonymous> YNotebook.insertCells http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16 YNotebook.insertCell http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21 webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22

- Drag and drop a cell

File editor memory leaks

Create a file

Memory change: -78.5 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
Detached HTMLUListElement	1	+2.3 kB
Detached V8EventHandlerNonNull	1	+40 B
VirtualElementPass	1	+38 B
Detached HTMLButtonElement	2	+23.7 kB
Detached SVGCircleElement	2	+1.1 kB
HTMLDivElement	2	+47 B
LabIcon	2	+1.07 kB
Detached CSSStyleDeclaration	3	+200 B
Detached HTMLLIElement	3	+5.21 kB
Detached NodeList	3	+184 B
NavigationHistoryEntry	3	+720 B
VirtualText	3	+109 B
Detached SVGGElement	4	+2.94 kB
VirtualElement	4	+981 B
Detached SVGAnimatedPreserveAspectRatio	5	+320 B
Detached SVGAnimatedRect	5	+320 B
Detached SVGPathElement	5	+1.77 kB
Detached SVGSVGElement	5	+7.92 kB
Detached HTMLSpanElement	6	+2.26 kB
Detached DOMStringMap	7	+368 B
Detached SVGAnimatedNumber	7	+448 B
Detached Attr	10	+720 B
Detached Text	10	+716 B
Detached HTMLCollection	13	+1.41 kB
Detached DOMTokenList	14	+896 B
Detached HTMLDivElement	15	+32.4 kB
Detached SVGAnimatedString	16	+896 B
Detached SVGAnimatedTransformList	16	+1.02 kB
Detached SVGAnimatedLength	26	+1.66 kB
Detached V8EventListener	130	+10.9 kB
Detached EventListener	131	+20.4 kB
(closure)	140	+25.8 kB

✔ Opening a text file (65085ms)

Notebook memory leaks

Create a notebook

Memory change: +37.1 kB Leak detected: Yes

Leaking objects:

Object	# added	Retained size increase
Detached HTMLUListElement	1	+2.21 kB
Detached V8EventHandlerNonNull	1	+40 B
VirtualElementPass	1	+46 B
Detached HTMLButtonElement	2	+23.4 kB
Detached SVGCircleElement	2	+1.1 kB
HTMLDivElement	2	+-993 B
LabIcon	2	+139 B
Detached CSSStyleDeclaration	3	+252 B
Detached HTMLLIElement	3	+5.99 kB
Detached NodeList	3	+240 B
NavigationHistoryEntry	3	+720 B
VirtualText	3	+108 B
VirtualElement	4	+1.15 kB
Detached SVGAnimatedPreserveAspectRatio	5	+320 B
Detached SVGAnimatedRect	5	+320 B
Detached SVGSVGElement	5	+9.28 kB
Detached HTMLSpanElement	6	+3.08 kB
Detached SVGGElement	6	+4.9 kB
Detached SVGPathElement	7	+2.47 kB
Detached SVGAnimatedNumber	9	+576 B
Detached Attr	10	+720 B
Detached Text	10	+700 B
Detached HTMLCollection	13	+1.35 kB
Detached DOMTokenList	15	+1.05 kB
Detached HTMLDivElement	15	+33.3 kB
Detached SVGAnimatedString	20	+1.12 kB
Detached SVGAnimatedTransformList	20	+1.28 kB
Detached SVGAnimatedLength	26	+1.66 kB
Detached V8EventListener	130	+10.9 kB
Detached EventListener	131	+20.4 kB
(closure)	138	+49.3 kB

✔ Opening a notebook (67627ms)

2 passing (6m)
1 pending
1 failing

   Adding a cell:

  Create a code cell - Objects leaking
  + expected - actual

  -1322
  +1308
  
  at file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:43:16
  at Array.forEach (<anonymous>)
  at expectNoLeaks (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:28:11)
  at testScenario (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:230:3)
  at async Context.<anonymous> (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/cell.test.mjs:7:5)

jtpio

Thanks!

Fix failing check_links job

47e0325

krassowski added maintenance tag:Documentation labels Mar 21, 2023

krassowski added this to the 4.0.0 milestone Mar 21, 2023

github-actions bot assigned krassowski Mar 21, 2023

github-actions bot added the documentation label Mar 21, 2023

andrii-i approved these changes Mar 21, 2023

View reviewed changes

andrii-i mentioned this pull request Mar 21, 2023

Align Extension manager buttonbar right #14205

Merged

jtpio approved these changes Mar 22, 2023

View reviewed changes

jtpio merged commit 297bee1 into jupyterlab:master Mar 22, 2023
79 of 88 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix failing `check_links` job #14243

Fix failing `check_links` job #14243

krassowski commented Mar 21, 2023 •

edited

jupyterlab-probot bot commented Mar 21, 2023

jtpio commented Mar 21, 2023

krassowski commented Mar 21, 2023

krassowski commented Mar 21, 2023

andrii-i left a comment •

edited

github-actions bot commented Mar 22, 2023 •

edited

jtpio left a comment

Fix failing check_links job #14243

Fix failing check_links job #14243

Conversation

krassowski commented Mar 21, 2023 • edited

References

Code changes

User-facing changes

Backwards-incompatible changes

jupyterlab-probot bot commented Mar 21, 2023

jtpio commented Mar 21, 2023

krassowski commented Mar 21, 2023

krassowski commented Mar 21, 2023

andrii-i left a comment • edited

Choose a reason for hiding this comment

github-actions bot commented Mar 22, 2023 • edited

Benchmark report

Cell memory leaks

File editor memory leaks

Notebook memory leaks

jtpio left a comment

Choose a reason for hiding this comment

Fix failing `check_links` job #14243

Fix failing `check_links` job #14243

krassowski commented Mar 21, 2023 •

edited

andrii-i left a comment •

edited

github-actions bot commented Mar 22, 2023 •

edited