Align Extension manager buttonbar right #14205

andrii-i · 2023-03-16T00:46:35Z

References

Fixes Install buttons in the extension manager are left aligned #14021

Code changes

Justifies Extension Manager buttonbar to flex-end so that buttons are right-aligned.

User-facing changes

Extension Manager buttonbar is right-aligned

Before:

After:

Backwards-incompatible changes

None

jupyterlab-probot · 2023-03-16T00:46:37Z

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

andrii-i · 2023-03-16T00:52:09Z

bot please update snapshots

github-actions · 2023-03-16T01:15:14Z

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table

Test file	large_code_notebook	large_md_notebook
open
`chromium`
actual	507 <- [563 - 584 - 629] -> 759	719 <- [1172 - 1196 - 1227] -> 1342
expected	510 <- [554 - 576 - 604] -> 764	1071 <- [1183 - 1204 - 1222] -> 1421
Mean relative change	2.2% ± 2.4%	-1.0% ± 1.4%
switch-from
`chromium`
actual	535 <- [651 - 663 - 682] -> 766	271 <- [333 - 364 - 392] -> 504
expected	580 <- [645 - 663 - 679] -> 893	293 <- [336 - 355 - 389] -> 462
Mean relative change	-1.3% ± 1.8%	-0.2% ± 3.0%
switch-to
`chromium`
actual	1132 <- [1169 - 1194 - 1230] -> 1363	747 <- [807 - 824 - 839] -> 926
expected	1100 <- [1163 - 1181 - 1211] -> 1474	775 <- [812 - 829 - 841] -> 877
Mean relative change	0.9% ± 1.4%	-0.2% ± 0.8%
close
`chromium`
actual	133 <- [149 - 154 - 161] -> 187	196 <- [203 - 208 - 216] -> 243
expected	139 <- [147 - 152 - 157] -> 192	193 <- [203 - 209 - 216] -> 251
Mean relative change	1.6% ± 2.0%	-0.4% ± 1.4%

Changes are computed with expected as reference.

@jupyterlab/benchmarks@1.0.0 test:mocha
mocha ./tests/

Waiting for localhost:8888
localhost:8888 is up

Cell memory leaks

Create a code cell

Memory change: +152 kB Leak detected: Yes

Leaking objects:

Object	# added	Retained size increase
ArraySearchMarker	1	+5 B
ContentDeleted	1	+16 B
ContentString	1	+72 B
Detached Text	1	+77 B
FocusTracker	1	+276 B
ObservableList	1	+60 B
OutputArea	1	+1.4 kB
OutputAreaModel	1	+115 B
Promise	1	+20 B
PromiseDelegate	1	+128 B
ResizeHandle	1	+47 B
RestorablePool	1	+304 B
UndoManager	1	+1.92 kB
WidgetTracker	1	+976 B
YArray	1	+164 B
YCodeCell	1	+107 B
YText	1	+254 B
Detached DOMStringMap	2	+92 B
Detached V8EventHandlerNonNull	2	+80 B
Set	2	+1.21 kB
YMap	2	+464 B
StackItem	3	+1.3 kB
ContentAny	4	+205 B
ContentType	4	+64 B
DeleteItem	4	+80 B
DeleteSet	6	+976 B
Detached HTMLCollection	6	+564 B
EventHandler	8	+267 B
ID	10	+200 B
Item	10	+1.08 kB
Detached DOMTokenList	13	+872 B
Detached Attr	14	+1.12 kB
Detached HTMLDivElement	14	+47 kB
Map	17	+2.63 kB
Signal	19	+319 B
Array	44	+5.57 kB
Detached V8EventListener	263	+23.4 kB
Detached EventListener	265	+42.6 kB
(closure)	270	+24.4 kB
Detached InternalNode	323	+45.3 kB

Leaking collections:

Type

Change

Preview

Size increased at

Array

+2

[StackItem, ...]

UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5

Array

+10

[Item, ...]

addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7

Set

+1

Set((anonymous function), ...)

                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                                                                     
Doc.on                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11                                         
new UndoManager           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14                                         
YCodeCell.setUndoManager  http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 
<unknown>                 http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15
Array.forEach             <anonymous>                                                                                                                                    
YNotebook.insertCells     http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16
YNotebook.insertCell      http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22

Create a markdown cell

Memory change: -238 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
ActivityMonitor	1	+294 B
ArraySearchMarker	1	+5 B
AttachmentsModel	1	+193 B
AttachmentsResolver	1	+14 B
CodeCellModel	1	+400 B
ContentString	1	+72 B
Debouncer	1	+3.46 kB
Detached HTMLAnchorElement	1	+316 B
Detached HTMLButtonElement	1	+5.31 kB
Detached HTMLHeadingElement	1	+1.04 kB
Error	1	+3.06 kB
MarkdownCell	1	+4.73 kB
MarkdownCellModel	1	+237 B
Poll	1	+3.7 kB
RenderMimeRegistry	1	+227 B
RenderedMarkdown	1	+66 B
Transaction	1	+860 B
TypeError	1	+301 B
YArray	1	+164 B
YArrayEvent	1	+357 B
YCodeCell	1	+107 B
YMarkdownCell	1	+45 B
Detached CSSStyleDeclaration	2	+120 B
Detached HTMLElement	2	+336 B
Detached V8EventHandlerNonNull	2	+5.04 kB
Promise	2	+3.06 kB
PromiseDelegate	2	+3.27 kB
UndoManager	2	+2.38 kB
YText	2	+473 B
Detached DOMStringMap	3	+132 B
ObservableMap	3	+381 B
StackItem	3	+1.33 kB
DeleteItem	4	+80 B
YMap	4	+872 B
ContentAny	5	+490 B
DeleteSet	6	+1 kB
ContentType	7	+112 B
Detached Text	7	+532 B
Set	8	+1.76 kB
Detached HTMLDivElement	10	+30.5 kB
Detached DOMTokenList	13	+788 B
ID	13	+416 B
Item	13	+1.75 kB
EventHandler	14	+442 B
Detached HTMLCollection	17	+1.76 kB
Map	27	+16.6 kB
Signal	28	+756 B
Detached V8EventListener	130	+10.9 kB
Detached EventListener	132	+25.5 kB
(closure)	152	+-38.7 kB
Detached InternalNode	162	+28.2 kB

Leaking collections:

Type	Change	Preview	Size increased at
Array	+1	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17 Signal.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24 webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33 invokeSlot http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17 Signal.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17 webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30 invokeSlot http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Array	+1	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17 Signal.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24 webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37 invokeSlot http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17 Signal.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17 webpack://jupyterlab/packages/notebook/src/widget.ts:1321:30 webpack://jupyterlab/packages/notebook/src/actions.tsx:408:28 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2719:15
Array	+1	[f0c478ba-f284-4b2a-8035-f767bf19c8da, ...]	webpack://jupyterlab/packages/notebook/src/actions.tsx:2503:37 Array.forEach <anonymous> webpack://jupyterlab/packages/notebook/src/actions.tsx:2498:21 webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2650:15 CommandRegistry.execute http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5748:33 CommandRegistry._executeKeyBinding http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5906:14 CommandRegistry.processKeydownEvent http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5846:18 JupyterLab.evtKeydown http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:4660:23
Array	+2	[StackItem, ...]	UndoManager.afterTransactionHandler http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15 webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.forEach <anonymous> webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.<anonymous> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27 webpack://jupyterlab/node_modules/lib0/function.js:19:0 cleanupTransactions http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9 Doc.transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array	+13	[Item, ...]	addStruct http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11 Item.integrate http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22 Array.forEach <anonymous> typeListInsertGenericsAfter http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11 typeListInsertGenerics http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14 YArray.insert http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set	+2	Set((anonymous function), ...)	webpack://jupyterlab/node_modules/lib0/observable.js:30:56 Doc.on http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11 new UndoManager http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14 YCodeCell.setUndoManager http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 <unknown> http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15 Array.forEach <anonymous> YNotebook.insertCells http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16 YNotebook.insertCell http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21 webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22

Create a raw cell

Memory change: +143 kB Leak detected: Yes

Leaking objects:

Object	# added	Retained size increase
ArraySearchMarker	1	+5 B
CodeCellModel	1	+400 B
ContentString	1	+690 B
Detached CSSStyleDeclaration	1	+64 B
Detached V8EventHandlerNonNull	1	+40 B
ObservableMap	1	+102 B
TypeError	1	+301 B
YArray	1	+164 B
YCodeCell	1	+107 B
YRawCell	1	+45 B
Detached DOMStringMap	2	+92 B
Set	2	+1.26 kB
UndoManager	2	+2.38 kB
YText	2	+693 B
StackItem	3	+1.33 kB
DeleteItem	4	+80 B
YMap	4	+872 B
ContentAny	5	+454 B
Detached HTMLCollection	5	+468 B
DeleteSet	6	+1 kB
ContentType	7	+112 B
Detached DOMTokenList	9	+564 B
Detached HTMLDivElement	9	+22.6 kB
Signal	11	+484 B
ID	13	+416 B
Item	13	+2.34 kB
EventHandler	14	+448 B
Map	19	+2.86 kB
Object	35	+27.6 kB
Detached V8EventListener	130	+10.9 kB
Detached EventListener	131	+20.4 kB
(closure)	140	+25.3 kB

Leaking collections:

Type	Change	Preview	Size increased at
Array	+1	[510698ab-216a-4be0-8305-10a70cadf078, ...]	webpack://jupyterlab/packages/notebook/src/actions.tsx:2503:37 Array.forEach <anonymous> webpack://jupyterlab/packages/notebook/src/actions.tsx:2498:21 webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2650:15 CommandRegistry.execute http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5748:33 CommandRegistry._executeKeyBinding http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5906:14 CommandRegistry.processKeydownEvent http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5846:18 JupyterLab.evtKeydown http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:4660:23
Array	+1	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17 Signal.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24 webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33 invokeSlot http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17 Signal.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17 webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30 invokeSlot http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Array	+1	[{signal, slot, thisArg}, ...]	Object.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17 Signal.connect http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24 webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37 invokeSlot http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18 Object.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17 Signal.emit http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17 webpack://jupyterlab/packages/notebook/src/widget.ts:1321:30 webpack://jupyterlab/packages/notebook/src/actions.tsx:408:28 webpack://jupyterlab/packages/notebook-extension/src/index.ts:2719:15
Array	+2	[StackItem, ...]	UndoManager.afterTransactionHandler http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15 webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.forEach <anonymous> webpack://jupyterlab/node_modules/lib0/observable.js:73:62 Array.<anonymous> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27 webpack://jupyterlab/node_modules/lib0/function.js:19:0 cleanupTransactions http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9 Doc.transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array	+13	[Item, ...]	addStruct http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11 Item.integrate http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22 Array.forEach <anonymous> typeListInsertGenericsAfter http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11 typeListInsertGenerics http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10 <unknown> http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9 transact http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14 YArray.insert http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set	+2	Set((anonymous function), ...)	webpack://jupyterlab/node_modules/lib0/observable.js:30:56 Doc.on http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11 new UndoManager http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14 YCodeCell.setUndoManager http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 <unknown> http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15 Array.forEach <anonymous> YNotebook.insertCells http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16 YNotebook.insertCell http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21 webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22

- Drag and drop a cell

File editor memory leaks

Create a file

Memory change: -76.8 kB Leak detected: No

Leaking objects:

Object	# added	Retained size increase
Detached HTMLUListElement	1	+3.18 kB
Detached V8EventHandlerNonNull	1	+40 B
VirtualElementPass	1	+46 B
Detached HTMLButtonElement	2	+23.8 kB
Detached SVGCircleElement	2	+1.12 kB
LabIcon	2	+1.09 kB
Detached CSSStyleDeclaration	3	+224 B
Detached HTMLLIElement	3	+6.08 kB
Detached NodeList	3	+192 B
NavigationHistoryEntry	3	+720 B
VirtualText	3	+109 B
Detached SVGGElement	4	+3 kB
VirtualElement	4	+2.14 kB
Detached SVGAnimatedPreserveAspectRatio	5	+320 B
Detached SVGAnimatedRect	5	+320 B
Detached SVGPathElement	5	+1.81 kB
Detached SVGSVGElement	5	+8.14 kB
Detached HTMLSpanElement	6	+2.38 kB
Detached DOMStringMap	7	+412 B
Detached SVGAnimatedNumber	7	+448 B
Detached Attr	10	+800 B
Detached Text	10	+992 B
Detached HTMLCollection	13	+1.42 kB
Detached DOMTokenList	14	+900 B
Detached HTMLDivElement	15	+34.1 kB
Detached SVGAnimatedString	16	+896 B
Detached SVGAnimatedTransformList	16	+1.02 kB
Detached SVGAnimatedLength	26	+1.66 kB
Array	42	+24.8 kB
Detached V8EventListener	130	+10.9 kB
Detached EventListener	131	+20.4 kB
(closure)	138	+24.5 kB

✔ Opening a text file (68256ms)

Notebook memory leaks

Create a notebook

Memory change: +26.5 kB Leak detected: Yes

Leaking objects:

Object	# added	Retained size increase
Detached HTMLUListElement	1	+2.37 kB
Detached V8EventHandlerNonNull	1	+40 B
VirtualElementPass	1	+55 B
Detached HTMLButtonElement	2	+23.8 kB
Detached SVGCircleElement	2	+1.12 kB
HTMLDivElement	2	+126 B
LabIcon	2	+131 B
Detached CSSStyleDeclaration	3	+240 B
Detached HTMLLIElement	3	+6.21 kB
Detached NodeList	3	+216 B
NavigationHistoryEntry	3	+720 B
VirtualText	3	+108 B
VirtualElement	4	+1.15 kB
Detached SVGAnimatedPreserveAspectRatio	5	+320 B
Detached SVGAnimatedRect	5	+320 B
Detached SVGSVGElement	5	+9.42 kB
Detached HTMLSpanElement	6	+3.15 kB
Detached SVGGElement	6	+5.02 kB
Detached SVGPathElement	7	+2.53 kB
Detached SVGAnimatedNumber	9	+576 B
Detached Attr	10	+800 B
Detached Text	10	+816 B
Detached HTMLCollection	13	+1.44 kB
Detached DOMTokenList	15	+1.02 kB
Detached HTMLDivElement	15	+33.8 kB
Detached SVGAnimatedString	20	+1.12 kB
Detached SVGAnimatedTransformList	20	+1.28 kB
Detached SVGAnimatedLength	26	+1.66 kB
Detached V8EventListener	130	+10.9 kB
Detached EventListener	131	+20.4 kB
(closure)	138	+36 kB

✔ Opening a notebook (71679ms)

2 passing (7m)
1 pending
1 failing

   Adding a cell:

  Create a code cell - Objects leaking
  + expected - actual

  -1322
  +1308
  
  at file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:43:16
  at Array.forEach (<anonymous>)
  at expectNoLeaks (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:28:11)
  at testScenario (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:230:3)
  at async Context.<anonymous> (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/cell.test.mjs:7:5)

github-actions · 2023-03-16T01:54:36Z

Galata snapshots updated.

andrii-i · 2023-03-16T18:13:11Z

Kicking CI

krassowski · 2023-03-19T22:50:31Z

👍 There is a conflict in galata/test/jupyterlab/completer.test.ts-snapshots/completer-with-doc-panel-jupyterlab-linux.png which needs to be resolved locally.

andrii-i · 2023-03-21T20:59:35Z

Kicking CI

andrii-i · 2023-03-21T22:25:16Z

Currently Linux Tests / check_links (pull_request) fails because there is a dead link in YDocument <https://jupyter-ydoc.readthedocs.io/en/latest/api/classes/YDocument.html> string in source/extension/documents.rst at line 42

andrii-i · 2023-03-21T22:45:22Z

Failing test is not related to this PR, see issue #14248 and PR #14243

andrii-i · 2023-03-22T18:10:02Z

@krassowski it's all green now. Could you please give it a look and merge if possible? Thank you

krassowski

Thank you!

We may decide to rework the placement of buttons with a more encompassing review of extension manager UX in the future but for now I believe this is an improvement for the design that we currently have.

andrii-i · 2023-03-27T00:37:05Z

Thank you @krassowski

github-actions bot assigned andrii-i Mar 16, 2023

github-actions bot added Design System CSS pkg:extensionmanager tag:CSS For general CSS related issues and pecadilloes labels Mar 16, 2023

andrii-i mentioned this pull request Mar 16, 2023

Install buttons in the extension manager are left aligned #14021

Closed

andrii-i changed the title ~~Extension manager buttonbar~~ Align Extension manager buttonbar right Mar 16, 2023

andrii-i force-pushed the extension-manager-buttonbar branch from 3da706e to fd56b0f Compare March 16, 2023 18:12

andrii-i closed this Mar 16, 2023

andrii-i reopened this Mar 16, 2023

github-actions bot added the tag:Testing label Mar 16, 2023

krassowski added the enhancement label Mar 19, 2023

krassowski added this to the 4.0.0 milestone Mar 19, 2023

andrii-i force-pushed the extension-manager-buttonbar branch 2 times, most recently from c42ce40 to d892688 Compare March 21, 2023 20:52

andrii-i closed this Mar 21, 2023

andrii-i reopened this Mar 21, 2023

andrii-i closed this Mar 21, 2023

andrii-i reopened this Mar 21, 2023

andrii-i force-pushed the extension-manager-buttonbar branch from d892688 to da8af78 Compare March 22, 2023 15:41

andrii-i added 2 commits March 22, 2023 09:40

justify buttons to flex-end

063bde6

Use logical block start instead of 'top' for padding

613a55a

Update Playwright Snapshots

8e6fe18

andrii-i force-pushed the extension-manager-buttonbar branch from da8af78 to 8e6fe18 Compare March 22, 2023 16:40

krassowski mentioned this pull request Mar 22, 2023

Binder build fail on PRs #14264

Closed

andrii-i requested a review from krassowski March 22, 2023 18:09

krassowski approved these changes Mar 24, 2023

View reviewed changes

krassowski merged commit 958b48a into jupyterlab:master Mar 26, 2023
75 of 78 checks passed

andrii-i deleted the extension-manager-buttonbar branch March 28, 2023 21:45

github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Align Extension manager buttonbar right #14205

Align Extension manager buttonbar right #14205

andrii-i commented Mar 16, 2023

jupyterlab-probot bot commented Mar 16, 2023

andrii-i commented Mar 16, 2023

github-actions bot commented Mar 16, 2023 •

edited

github-actions bot commented Mar 16, 2023

andrii-i commented Mar 16, 2023

krassowski commented Mar 19, 2023

andrii-i commented Mar 21, 2023

andrii-i commented Mar 21, 2023

andrii-i commented Mar 21, 2023 •

edited

andrii-i commented Mar 22, 2023

krassowski left a comment •

edited

andrii-i commented Mar 27, 2023

Align Extension manager buttonbar right #14205

Align Extension manager buttonbar right #14205

Conversation

andrii-i commented Mar 16, 2023

References

Code changes

User-facing changes

Backwards-incompatible changes

jupyterlab-probot bot commented Mar 16, 2023

andrii-i commented Mar 16, 2023

github-actions bot commented Mar 16, 2023 • edited

Benchmark report

Cell memory leaks

File editor memory leaks

Notebook memory leaks

github-actions bot commented Mar 16, 2023

andrii-i commented Mar 16, 2023

krassowski commented Mar 19, 2023

andrii-i commented Mar 21, 2023

andrii-i commented Mar 21, 2023

andrii-i commented Mar 21, 2023 • edited

andrii-i commented Mar 22, 2023

krassowski left a comment • edited

Choose a reason for hiding this comment

andrii-i commented Mar 27, 2023

github-actions bot commented Mar 16, 2023 •

edited

andrii-i commented Mar 21, 2023 •

edited

krassowski left a comment •

edited