-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove padding in DialogContent
#3427
Conversation
🦋 Changeset detectedLatest commit: b2cc5a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DialogContent
DialogContent
We probably need to live with this, unless there's a way to add padding only when scroll bar appears |
I don't think there's a nice way of adding padding for the scroll bar, there are some hacks like adding a transparent thicker border to it but it's not really ideal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update QA stories, so that right spacing change could be captured in Chromatic
Just added a QA story 👍 |
@navkaur76 does any of padding removal impact pref dialog pattern? |
2587dc4
to
b2cc5a2
Compare
Preview at https://14c812da.saltdesignsystem-storybook.pages.dev/?path=/story/core-dialog--long-content