Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog spacing is not on spec #3359

Closed
1 of 10 tasks
origami-z opened this issue May 2, 2024 · 0 comments · Fixed by #3427
Closed
1 of 10 tasks

Dialog spacing is not on spec #3359

origami-z opened this issue May 2, 2024 · 0 comments · Fixed by #3427
Labels
community For issues that have been raised by folks outside the core Salt team component: dialog status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: bug 🪲 Something isn't working

Comments

@origami-z
Copy link
Contributor

origami-z commented May 2, 2024 •
edited

Package name(s)

Core (@salt-ds/core)

Package version(s)

No response

Description

Dialog spacing is not even left/right, should be spacing-300 on all sizes

image

Steps to reproduce

No response

Expected behavior

No response

Operating system

  • macOS
  • Windows
  • Linux
  • iOS
  • Android

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@origami-z origami-z added type: bug 🪲 Something isn't working status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. community For issues that have been raised by folks outside the core Salt team component: dialog labels May 2, 2024
@JoanaMMoreira JoanaMMoreira linked a pull request May 15, 2024 that will close this issue
Remove padding in DialogContent #3427
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community For issues that have been raised by folks outside the core Salt team component: dialog status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: bug 🪲 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove padding in DialogContent jpmorganchase/salt-ds
1 participant
@origami-z