Remove deprecated spotbugsXmlOutput setting #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://spotbugs.github.io/spotbugs-maven-plugin/spotbugs-mojo.html says that it is deprecated and gives no reason for the deprecation. Since the value was faluse, it seems safe to remove the setting. Fixes jenkinsci#716 jenkinsci#716 is the issue report.
basil
reviewed
Mar 16, 2023
| @@ -680,7 +680,6 @@ | |||
| presence of this file. | |||
| --> | |||
| <xmlOutput>true</xmlOutput> | |||
| <spotbugsXmlOutput>false</spotbugsXmlOutput> | |||
There was a problem hiding this comment.
Based on my local tests, deleting this entire <configuration> block still gives us the result we want (generating a spotbugsXml.xml file for Jenkins), so I think we should just delete the whole block: the less code there is to maintain, the better. The comment about excludeFilterFile is valuable, but it could just be moved to below <phase>verify</phase>.
Also the same change needs to be made to jenkinsci/pom for consistency.
6 tasks
MarkEWaite
added a commit
to MarkEWaite/pom
that referenced
this pull request
Mar 17, 2023
https://spotbugs.github.io/spotbugs-maven-plugin/spotbugs-mojo.html says that it is deprecated and gives no reason for the deprecation. Since the value was false, it seems safe to remove the setting. Fixes jenkinsci/plugin-pom#716 jenkinsci/plugin-pom#722 is the matching pull request in the plugin pom.
basil
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated spotbugsXmlOutput setting
https://spotbugs.github.io/spotbugs-maven-plugin/spotbugs-mojo.html says that it is deprecated and gives no reason for the deprecation. Since the value was faluse, it seems safe to remove the setting.
Fixes #716
#716 is the issue report.