Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated spotbugsXmlOutput setting #722

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Remove deprecated spotbugsXmlOutput setting #722

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a865956
Remove deprecated spotbugsXmlOutput setting
MarkEWaite Mar 16, 2023
184ccb0
Remove unnecessary spotbugs configuration section
MarkEWaite Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 5 additions & 9 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,15 +673,11 @@
<goal>check</goal>
</goals>
<phase>verify</phase>
<configuration>
<!--
Do not define "excludeFilterFile" here, as it will force consumers to provide a file.
Instead, we configure this below in a profile conditionally activated based on the
presence of this file.
-->
<xmlOutput>true</xmlOutput>
<spotbugsXmlOutput>false</spotbugsXmlOutput>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my local tests, deleting this entire <configuration> block still gives us the result we want (generating a spotbugsXml.xml file for Jenkins), so I think we should just delete the whole block: the less code there is to maintain, the better. The comment about excludeFilterFile is valuable, but it could just be moved to below <phase>verify</phase>.

Also the same change needs to be made to jenkinsci/pom for consistency.

</configuration>
<!--
Do not define "excludeFilterFile" here, as it will force consumers to provide a file.
Instead, we configure this below in a profile conditionally activated based on the
presence of this file.
-->
</execution>
</executions>
</plugin>
Expand Down