Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated spotbugsXmlOutput setting #403

Merged

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Mar 17, 2023

Remove deprecated spotbugsXmlOutput setting

https://spotbugs.github.io/spotbugs-maven-plugin/spotbugs-mojo.html says that it is deprecated and gives no reason for the deprecation. Since the value was false, it seems safe to remove the setting.

Fixes #400

jenkinsci/plugin-pom#722 is the matching pull request in the plugin pom.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

https://spotbugs.github.io/spotbugs-maven-plugin/spotbugs-mojo.html
says that it is deprecated and gives no reason for the deprecation.
Since the value was false, it seems safe to remove the setting.

Fixes jenkinsci/plugin-pom#716

	jenkinsci/plugin-pom#722 is the matching pull
request in the plugin pom.
@MarkEWaite MarkEWaite added the bug label Mar 17, 2023
@basil basil merged commit b022058 into jenkinsci:master Mar 17, 2023
@MarkEWaite MarkEWaite deleted the avoid-spotbugs-deprecation-message branch March 17, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Parameter spotbugsXmlOutput is deprecated: No reason given" warning
2 participants