Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes invalid context expectation in test #287

Conversation

alecharp
Copy link
Member

The workflow-step-api plugin changed the wording on the invalid context error. It has to be updated here as well.
cc @jglick

Testing done

Running the test with only the pom update and then updated the text string expectation.
This is a follow of jenkinsci/workflow-step-api-plugin#143 and coming from jenkinsci/bom#2846

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@alecharp alecharp requested a review from a team as a code owner January 19, 2024 16:31
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better still to update

throw new MissingContextVariableException(FilePath.class);
to the new constructor. I can do that as a follow-up though.

@@ -70,6 +70,7 @@
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-step-api</artifactId>
<version>655.v6e098b_87b_84f</version> <!-- TODO: Removes once the plugin is updated in the BOM -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I have adopted the convention of putting overrides like this into dependencyManagement, mainly so that they are textually right next to the bom-* dep and thus apparent when evaluating Dependabot bumps that would allow the override to be deleted.

@jglick jglick merged commit 2b19db7 into jenkinsci:master Jan 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants