Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump org.jenkins-ci.plugins.workflow:workflow-step-api in /bo… #2846

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

alecharp
Copy link
Member

@alecharp alecharp commented Jan 19, 2024

…m-weekly (#2845)"

This reverts commit 6b58cd0.

Testing done

Running local-test script locally with PLUGINS=credentials-binding.
This because I detected a problem on the release preparation work. Doing a bisect showed that the problem was the version bump of workflow-step-api. Additional research showed that the problem came from jenkinsci/workflow-step-api-plugin#143.

Initial error report can be seen here: https://ci.jenkins.io/job/Tools/job/bom/job/master/2425/pipeline-console/

cc @jglick

The problem can be reproduced outside of the BOM by running mvn clean verify -Dtest=org.jenkinsci.plugins.credentialsbinding.impl.BindingStepTest#widerRequiredContext on credentials-binding. The pull request on workflow-step-api changed the wording of the context error but that was not updated in the credentials-binding test.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@alecharp alecharp requested a review from a team as a code owner January 19, 2024 16:11
.github/dependabot.yml Outdated Show resolved Hide resolved
@basil basil merged commit b92a39d into master Jan 19, 2024
2 of 4 checks passed
@basil basil deleted the fix/revert-workflow-step-api-657 branch January 19, 2024 16:39
@basil
Copy link
Member

basil commented Jan 19, 2024

If jenkinsci/credentials-binding-plugin#287 isn't merged and released in a short timeframe, please file a BOM issue to track the removal of this workaround. (No need for the formality if the fix is imminent, but want to keep us from losing track if the fix takes longer.)

@jglick
Copy link
Member

jglick commented Jan 19, 2024

#2848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants