Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix support for defaultNS as array (fixes #2118) #2121

Merged
merged 3 commits into from Jan 20, 2024

Conversation

marcalexiei
Copy link
Member

Fixes #2118.

The main difference from #2119 is that I tried to take into account all namespaces included in defaultNS when providing it as an array.


Before marking this PR ready for review I would like to see what I can do to deduce test code.
I hope to have something ready tomorrow.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

coveralls commented Jan 19, 2024

Coverage Status

coverage: 96.239%. remained the same
when pulling 79771d8 on marcalexiei:feature/default-ns-as-array
into 44e132d on i18next:master.

@marcalexiei
Copy link
Member Author

@adrai I don't know why circleci chec is performed again. For example in PR #2112 the check wasn't present.
I don't think this is issue an issue but just wait to point out this strange behaviour.

@adrai
Copy link
Member

adrai commented Jan 19, 2024

I think we can ignore the circleci check here... should not be related to this pr

@marcalexiei marcalexiei marked this pull request as ready for review January 20, 2024 09:35
@marcalexiei
Copy link
Member Author

@adrai PR is ready for review!

@adrai adrai merged commit 57d3f48 into i18next:master Jan 20, 2024
6 of 7 checks passed
@adrai
Copy link
Member

adrai commented Jan 20, 2024

thank you, it's included in v23.7.17

@marcalexiei marcalexiei deleted the feature/default-ns-as-array branch January 20, 2024 12:32
@EvertEt EvertEt mentioned this pull request Jan 20, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global t does not handle arrays as defaultNS well
3 participants