Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix typo in CustomInstanceExtensions #2122

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

marcalexiei
Copy link
Member

During #2121 I noticed a typo in CustomInstanceExtensions so I corrected it.
I don't know if this should be considered a breaking change or a bug but there is no mention in the doc of this interface (https://www.i18next.com/?q=CustomInstanceExtensions), hence I think it can be considered a fix.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • (N/A) tests are included
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

Coverage Status

coverage: 96.239%. remained the same
when pulling 6ad199b on marcalexiei:feature/fix-types-interface-typo
into 44e132d on i18next:master.

@adrai
Copy link
Member

adrai commented Jan 20, 2024

Only used here: https://github.com/i18next/react-i18next/blob/26f83a89b30c8b25a0d400d45d7d63525d5f9c28/index.d.ts#L40
so also react-i18next needs to be fixed.
currently afk... will check in a couple of hours

@marcalexiei
Copy link
Member Author

Gotcha, I'll open also a PR there.

@adrai adrai merged commit 367bb8a into i18next:master Jan 20, 2024
6 of 7 checks passed
@adrai
Copy link
Member

adrai commented Jan 20, 2024

thanks a lot

@marcalexiei marcalexiei deleted the feature/fix-types-interface-typo branch January 20, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants