fix(fielder): batch calls to SetAttributes #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizthegrey
added a commit
that referenced
this pull request
Jan 9, 2024
## Which problem is this PR solving? - `span.SetAttributes()` even with batching of the attributes in one call from #34, will add them all to the inner `s.attributes` object one at a time, causing excess `growslice` calls. ## Short description of the changes - Cherry-picks in open-telemetry/opentelemetry-go#4818 for improved performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
fielder.AddFields()is very inefficient, callingspan.SetAttributes()once per field set. We can optimise/batch this.Short description of the changes
span.SetAttributes()to ensure efficient memory allocations, decreasing garbage & growslice. Alternative to try first before pushing sdk/trace: use slices.Grow() to avoid excessive runtime.growslice() open-telemetry/opentelemetry-go#4818 forward.