Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary call to DetermineRoleFromLoginRequest #22603

Merged
merged 3 commits into from Aug 29, 2023

Conversation

elliesterner
Copy link
Contributor

Sorry I forgot one reference in last PR!
#22583

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 29, 2023
@elliesterner elliesterner modified the milestones: 1.14.3, 1.14.2 Aug 29, 2023
@elliesterner elliesterner added backport/1.14.x Backport changes to `release/1.14.x` backport/1.13.x Backport changes to `release/1.13.x` backport/1.12.x labels Aug 29, 2023
vault/wrapping.go Outdated Show resolved Hide resolved
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@elliesterner elliesterner merged commit 9b78fd6 into main Aug 29, 2023
98 checks passed
@elliesterner elliesterner deleted the remove-determine-role-call branch August 29, 2023 14:56
elliesterner added a commit that referenced this pull request Aug 29, 2023
* remove unnecessary call to DetermineRoleFromLoginRequest

* add more context to comment
elliesterner added a commit that referenced this pull request Aug 29, 2023
…2621)

* remove unnecessary call to DetermineRoleFromLoginRequest

* add more context to comment

Co-authored-by: Ellie <ellie.sterner@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.13.x Backport changes to `release/1.13.x` backport/1.14.x Backport changes to `release/1.14.x` hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants