New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary call to DetermineRoleFromLoginRequest #22603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Aug 29, 2023
elliesterner
added
backport/1.14.x
Backport changes to `release/1.14.x`
backport/1.13.x
Backport changes to `release/1.13.x`
backport/1.12.x
labels
Aug 29, 2023
mpalmi
approved these changes
Aug 29, 2023
VioletHynes
reviewed
Aug 29, 2023
VioletHynes
approved these changes
Aug 29, 2023
Build Results: |
CI Results: |
elliesterner
force-pushed
the
remove-determine-role-call
branch
from
August 29, 2023 14:36
590899d
to
b8b7eac
Compare
This was referenced Aug 29, 2023
Merged
Merged
elliesterner
added a commit
that referenced
this pull request
Aug 29, 2023
* remove unnecessary call to DetermineRoleFromLoginRequest * add more context to comment
elliesterner
added a commit
that referenced
this pull request
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.13.x
Backport changes to `release/1.13.x`
backport/1.14.x
Backport changes to `release/1.14.x`
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
pr/no-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I forgot one reference in last PR!
#22583