Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Remove unnecessary call to DetermineRoleFromLoginRequest into release/1.12.x #22621

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Backport of Remove unnecessary call to DetermineRoleFromLoginRequest into release/1.12.x #22621

merged 1 commit into from
Aug 29, 2023

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #22603 to be assessed for backporting due to the inclusion of the label backport/1.12.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@elliesterner
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.

Sorry I forgot one reference in last PR!
#22583

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/remove-determine-role-call/pleasantly-feasible-fish branch from 66ecdb8 to bfa4f2e Compare August 29, 2023 20:22
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/remove-determine-role-call/pleasantly-feasible-fish branch from bfa4f2e to 66ecdb8 Compare August 29, 2023 20:22
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 29, 2023
@hashicorp-cla
Copy link

hashicorp-cla commented Aug 29, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@elliesterner
Remove unnecessary call to DetermineRoleFromLoginRequest (#22603)
eec3d23 
* remove unnecessary call to DetermineRoleFromLoginRequest

* add more context to comment
@elliesterner elliesterner force-pushed the backport/remove-determine-role-call/pleasantly-feasible-fish branch from 2e5df02 to eec3d23 Compare August 29, 2023 20:37
@elliesterner elliesterner marked this pull request as ready for review August 29, 2023 20:37
@elliesterner elliesterner added this to the 1.12.11 milestone Aug 29, 2023
@elliesterner elliesterner enabled auto-merge (squash) August 29, 2023 20:48
@elliesterner elliesterner merged commit fb5f2c1 into release/1.12.x Aug 29, 2023
72 of 81 checks passed
@elliesterner elliesterner deleted the backport/remove-determine-role-call/pleasantly-feasible-fish branch August 29, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliesterner elliesterner elliesterner approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.12.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hc-github-team-secure-vault-core @hashicorp-cla @elliesterner