Revert changes to STS leases but keep the ttl field

[kschoche]

• Reverts lease changes brought in by don't create leases for AWS STS secrets #15869 while keeping the ttl changes.
• Fixes AWS secrets engine no longer returns lease_duration for STS credentials #19513

[austingebauer]

LGTM

[alex-ikse]

Will fix: hashicorp/terraform-provider-vault#1805

[maxb]

But this is going to revert the efficiency optimization which was the original purpose of removing the leases too...

Wouldn't it be better to aim for a solution that gave clients the necessary compatible feedback in responses, but also retained the optimization?

[robmonte]

👍

[alex-ikse]

Wouldn't it be better to aim for a solution that gave clients the necessary compatible feedback in responses, but also retained the optimization?

Terraform Vault provider must be updated before doing this kind of change. See: hashicorp/terraform-provider-vault#1805

[kschoche]

But this is going to revert the efficiency optimization which was the original purpose of removing the leases too...

Wouldn't it be better to aim for a solution that gave clients the necessary compatible feedback in responses, but also retained the optimization?

Hi @maxb - Thanks for pointing this out. Right now, it’s our first priority to fix the broken clients. We can circle back and introduce a no_lease option in the future for those who are concerned about the cost of the lease.