secrets/aws: create leases by default #19923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The existing issue mentioned in this PR has been resolved with 1.13.2, however, we will be leaving this PR open for now as a potential solution for adding the feature back in at a future date after this approach has been investigated. Thanks for your enthusiasm and support! |
|
Hey there! I'm going to close this since it seems this was resolved by #20034, and there are many merge conflicts. If you think this is still valid, please feel free to raise another PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #15869 because not creating leases is causing issues. (see #19513)
This PR adds a
no_leaseoption for aws secrets roles that is disabled by default. Only when this option is enabled will leases not be create for assumed role and federated token credentials.The only other fix I know of is to revert #15869