Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: go get github.com/hashicorp/terraform-svchost@v0.1.1 #33364

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

apparentlymart
Copy link
Member

This includes a change to make svchost.Disco and the caching credentials source both safe for concurrent calls.

This fixes #33333.

This includes a change to make svchost.Disco and the caching credentials
source both safe for concurrent calls.
@apparentlymart apparentlymart requested a review from a team June 13, 2023 19:19
@apparentlymart apparentlymart self-assigned this Jun 13, 2023
@apparentlymart
Copy link
Member Author

I've marked this as a draft because this upgrade also forced upgrading a few of our other dependencies and so I need to go see what has changed in those and whether those upgrades will have any other impacts on Terraform. I'll mark this as ready to review once I've reached a conclusion on that, and hopefully also request a v1.5 backport if those upstream changes are low-risk.

@apparentlymart
Copy link
Member Author

  • golang.org/x/net changes: Only affects the "html" package, which we don't use in Terraform. (We use this module for its IDNA and HTTP proxy functionality.)
  • golang.org/x/oauth2 changes: Seems to primarily affect the Google-specific package, which we don't use in Terraform Core. I worried that the gcs backend might use the Google-specific parts, but it seems not; it only imports the root package.
  • golang.org/x/sys changes: We use only the "windows" package, and that is affected by two of the upstream changes but it doesn't seem to change the parts we depend on. (We use this for atomically renaming files using MoveFileEx, and for activating the VT features of the Windows console using GetConsoleMode and SetConsoleMode.)
  • golang.org/x/term changes: This hasn't actually changed itself; it just depends on golang.org/x/sys v0.6.0 now itself.

All of these seem low-risk to me, so I'm going to propose this for v1.5 backport.

@apparentlymart apparentlymart added the 1.5-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Jun 13, 2023
@apparentlymart apparentlymart marked this pull request as ready for review June 13, 2023 21:26
@apparentlymart apparentlymart merged commit 237877f into main Jun 14, 2023
6 checks passed
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.5-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform fatal error: concurrent map read and map write
2 participants