Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of go.mod: go get github.com/hashicorp/terraform-svchost@v0.1.1 into v1.5 #33367

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #33364 to be assessed for backporting due to the inclusion of the label 1.5-backport.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


This includes a change to make svchost.Disco and the caching credentials source both safe for concurrent calls.

This fixes #33333.

@teamterraform teamterraform force-pushed the backport/b-svchost-race-panic/evidently-intense-horse branch from 3aa3137 to 0adc0b8 Compare June 14, 2023 14:37
@teamterraform teamterraform force-pushed the backport/b-svchost-race-panic/evidently-intense-horse branch from 0adc0b8 to 3aa3137 Compare June 14, 2023 14:37
@hashicorp-cla
Copy link

hashicorp-cla commented Jun 14, 2023

CLA assistant check
All committers have signed the CLA.

This includes a change to make svchost.Disco and the caching credentials
source both safe for concurrent calls.
@apparentlymart
Copy link
Member

Seems like something in the dependencies here has dragged us forward onto cty 1.13, which includes the refinements changes that Terraform v1.5 is not ready to accept. I'm going to see if I can find some way to avoid that upgrade here, but if not then we will probably just need to hold this fix for v1.6. That's not a huge deal since it's a bug that's relatively hard to hit, but it is a crasher so if we can't backport this then I'll spend a little time seeing if there's something more surgical we can do in v1.5, such as putting a mutex directly inside the terraform_remote_state data source.

@apparentlymart
Copy link
Member

Unfortunately it's svchost itself that has the updated dependency, so I'm going to abandon this backport and pursue a safer fix for the v1.5 branch. We'll keep the main branch equivalent of this PR as the moving-forward solution for v1.6 onwards, since it uses more fine-grain locking that we won't be able to achieve just as a caller.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants