-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifier hds-anchored-position
- Convert to TypeScript
#2104
base: hds-register-event-ts-conversion
Are you sure you want to change the base?
Modifier hds-anchored-position
- Convert to TypeScript
#2104
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
edce147
to
d36152c
Compare
8bb9481
to
8677479
Compare
8677479
to
3c86721
Compare
fa1961e
to
c4a840f
Compare
603562e
to
5cda928
Compare
c4a840f
to
b5be7e8
Compare
5cda928
to
6de82ce
Compare
b5be7e8
to
e5d8530
Compare
15f5f3b
to
50dcd5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left only one suggestion.
Is this branch meant to be pointed to main
? I don't see the register-event modifier depending on it
09d163c
to
27779af
Compare
9098ad9
to
0b05d35
Compare
@alex-ju there's only a tiny dependency, but also it helps me in remembering in which order to the rebase (there are four PRs related) |
27779af
to
11dc561
Compare
0b05d35
to
f8e0fe1
Compare
11dc561
to
6ce3d92
Compare
f8e0fe1
to
22a46eb
Compare
📌 Summary
Converts the
hds-anchored-position
modifier to TypeScript🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-3338
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.