Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifier hds-anchored-position - Convert to TypeScript #2104

Open
wants to merge 8 commits into
base: hds-register-event-ts-conversion
Choose a base branch
from

Conversation

didoo
Copy link
Contributor

@didoo didoo commented May 16, 2024

📌 Summary

Converts the hds-anchored-position modifier to TypeScript

🔗 External links

Jira ticket: https://hashicorp.atlassian.net/browse/HDS-3338


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@didoo didoo requested a review from a team May 16, 2024 14:59
Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview May 22, 2024 11:37am
hds-website ✅ Ready (Inspect) Visit Preview May 22, 2024 11:37am

@didoo didoo force-pushed the hds-register-event-ts-conversion branch from edce147 to d36152c Compare May 16, 2024 15:57
@didoo didoo force-pushed the hds-anchored-position-ts-conversion branch from 8bb9481 to 8677479 Compare May 16, 2024 16:35
@didoo didoo force-pushed the hds-anchored-position-ts-conversion branch from 8677479 to 3c86721 Compare May 16, 2024 17:03
@didoo didoo force-pushed the hds-anchored-position-ts-conversion branch from fa1961e to c4a840f Compare May 17, 2024 07:27
@didoo didoo force-pushed the hds-register-event-ts-conversion branch from 603562e to 5cda928 Compare May 17, 2024 10:34
@didoo didoo force-pushed the hds-anchored-position-ts-conversion branch from c4a840f to b5be7e8 Compare May 17, 2024 10:37
Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left only one suggestion.

Is this branch meant to be pointed to main? I don't see the register-event modifier depending on it

@didoo didoo force-pushed the hds-register-event-ts-conversion branch from 09d163c to 27779af Compare May 21, 2024 09:27
@didoo didoo changed the base branch from hds-register-event-ts-conversion to main May 21, 2024 09:28
@didoo didoo changed the base branch from main to hds-register-event-ts-conversion May 21, 2024 09:31
@didoo didoo force-pushed the hds-anchored-position-ts-conversion branch 2 times, most recently from 9098ad9 to 0b05d35 Compare May 21, 2024 09:32
@didoo
Copy link
Contributor Author

didoo commented May 21, 2024

Is this branch meant to be pointed to main? I don't see the register-event modifier depending on it

@alex-ju there's only a tiny dependency, but also it helps me in remembering in which order to the rebase (there are four PRs related)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants