-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RichTooltip
- Convert to TypeScript
#2106
base: main
Are you sure you want to change the base?
Conversation
β¦ents/hds/popover-primitive`
β¦ents/hds/ rich-tooltip`
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
// TODO! | ||
const relatedTarget: EventTarget | null = event.relatedTarget; | ||
const activeElement: Node | null = document.activeElement; | ||
const xxx = relatedTarget || activeElement; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(question) any particular reason for this const
naming here? It seems not quite descriptive enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is still in draft, waiting for #2105 to be "resolved" (changes in that PR would impact this PR too)
π Summary
β Currently it doesn't compile because of an error I need to investigate β
Converts
RichTooltip
to TypeScript.Depends on #2103, #2104, and #2105.
π External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-3340
π Component checklist
π¬ Please consider using conventional comments when reviewing this PR.