Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[core] Add support for vsock transport" #33276

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

drfloob
Copy link
Member

@drfloob drfloob commented May 30, 2023

Reverts #32847. Breaks the Python build.

@drfloob drfloob requested a review from markdroth as a code owner May 30, 2023 20:22
@drfloob drfloob requested a review from gnossen May 30, 2023 20:23
@drfloob
Copy link
Member Author

drfloob commented May 30, 2023

CC @YadongQi

@drfloob drfloob added the release notes: no Indicates if PR should not be in release notes label May 30, 2023
@drfloob drfloob enabled auto-merge (squash) May 30, 2023 20:30
@drfloob drfloob merged commit c5ade30 into master May 30, 2023
62 of 66 checks passed
@drfloob drfloob deleted the revert-32847-vsock_up branch May 30, 2023 21:31
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label May 30, 2023
YadongQi added a commit to YadongQi/grpc that referenced this pull request Jun 1, 2023
eugeneo pushed a commit to eugeneo/grpc that referenced this pull request Jun 1, 2023
drfloob added a commit that referenced this pull request Jun 7, 2023
Revert "Revert "[core] Add support for vsock transport"
(#33276)"
This reverts commit
c5ade30.

And fix the issue which broke the python build.

@markdroth @drfloob please review this PR. Thank you very much.

---------

Co-authored-by: AJ Heller <hork@google.com>
mario-vimal pushed a commit to mario-vimal/grpc that referenced this pull request Jun 15, 2023
mario-vimal pushed a commit to mario-vimal/grpc that referenced this pull request Jun 15, 2023
Revert "Revert "[core] Add support for vsock transport"
(grpc#33276)"
This reverts commit
grpc@c5ade30.

And fix the issue which broke the python build.

@markdroth @drfloob please review this PR. Thank you very much.

---------

Co-authored-by: AJ Heller <hork@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bloat/improvement imported Specifies if the PR has been imported to the internal repository lang/core per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants