Add Virtio VSOCK support #1410
Add Virtio VSOCK support #1410
Conversation
examples/src/vsock/client.rs
Outdated
| // Use vsock-loopback so we don't need to spin up a VM. Must match server. | ||
| static TEST_CID: u32 = vsock::VMADDR_CID_LOCAL; | ||
| // Arbitrarily choosen. Must match server. | ||
| static TEST_PORT: u32 = 8000; |
There was a problem hiding this comment.
Personally I would prefer to store this in a public variable and import them in both client & server.
However, I decided to repeat them in each place they are used, to match the other examples & tests.
| // Virtio VSOCK does not use URIs, hence this URI will never be used. | ||
| // It is defined purely since in order to create a channel, since a URI has to | ||
| // be supplied to create an `Endpoint`. | ||
| static IGNORED_ENDPOINT_URI: &str = "file://[::]:0"; |
There was a problem hiding this comment.
Not proud of this, but this matches the code of the UDS example.
In the long term it would probably be a good idea to update the endpoint struct to no longer require a URI. However that should be done in a separate PR and it'd be a breaking change.
gRPC recently merged support for Virtio VSOCK as transport. It would be helpful for us if tonic were to match gRPC's support for it. gRPC PR that adds VSOCK support: grpc/grpc#33309
jul-sh
force-pushed
the
add-vsock-support
branch
from
1d9c94b
to
0181e33
Compare
|
cc @LucioFranco for review |
|
I believe a lot of this could be achieved outside of tonic. So I don't see why we should add another dependency when you can new type and wrap it in your own code? I am weary of adding this project as a dependency as well since it states:
In the readme, while I probably trust the code I wouldn't want to include it in a wide spread project like this. IF for some reason you can't work around it then we should try to fix that problem. Thanks! |
Motivation
gRPC recently merged support for Virtio VSOCK as transport. It would be helpful for us if tonic were to match gRPC's support for it.
gRPC PR that adds VSOCK support: grpc/grpc#32847
Solution
Add Virtio VSOCK support, integration test, and example
cc @tiziano88