[xDS] pass HTTP filter name to GenerateServiceConfig() method.
#32976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockspore
added
the
release notes: no
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/low
labels
markdroth
changed the title
GenerateServiceConfig() method
markdroth
approved these changes
May 1, 2023
| @@ -303,7 +303,8 @@ TEST_F(XdsFaultInjectionFilterTest, ModifyChannelArgs) { | |||
| TEST_F(XdsFaultInjectionFilterTest, GenerateServiceConfigTopLevelConfig) { | |||
| XdsHttpFilterImpl::FilterConfig config; | |||
| config.config = Json::Object{{"foo", "bar"}}; | |||
| auto service_config = filter_->GenerateServiceConfig(config, nullptr); | |||
| auto service_config = | |||
| filter_->GenerateServiceConfig(config, nullptr, "" /*filter_name=*/); | |||
There was a problem hiding this comment.
Please change this to be /*filter_name=*/"".
Same thing throughout.
There was a problem hiding this comment.
Thanks, Mark! Fixed.
rockspore
changed the title
GenerateServiceConfig() methodGenerateServiceConfig() method.
copybara-service
bot
added
the
imported
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
May 4, 2023
…c#32976) We need the RBAC filter name as the `policy_name` field in audit logging context.
yijiem
added
release notes: yes
erm-g
removed
the
release notes: yes
yijiem
added
the
release notes: no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the RBAC filter name as the
policy_namefield in audit logging context.