[Audit Logging] Authz policy support for audit logging #32944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
markdroth
reviewed
May 1, 2023
rockspore
changed the title
markdroth
approved these changes
May 2, 2023
| Rbac::Rbac(Rbac::Action action, std::map<std::string, Policy> policies, | ||
| absl::string_view name) | ||
| : action(action), policies(std::move(policies)), name(name) {} | ||
| Rbac::Rbac(absl::string_view name, Rbac::Action action, |
There was a problem hiding this comment.
Might as well take the name parameter as std::string instead of absl::string_view, since we're making a copy anyway. That way, if a caller happens to have a temp string that they don't need to keep, they can pass it in with std::move() and avoid the copy.
There was a problem hiding this comment.
Done. Thanks for the tip!
| @@ -394,7 +392,8 @@ ParseAuditLogger(const Json& json, size_t pos) { | |||
| absl::StrFormat("\"audit_loggers[%d].name\" is not a string.", pos)); | |||
| } | |||
| absl::string_view name = it->second.string(); | |||
| Json config = Json::Object(); | |||
| // The config defaults to an empty object. | |||
| Json config = Json::FromObject(Json::Object()); | |||
There was a problem hiding this comment.
Can just say Json::FromObject({}). The compiler is smart enough to know the type of the {}.
erm-g
approved these changes
May 2, 2023
rockspore
changed the title
copybara-service
bot
added
the
imported
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
May 4, 2023
Add audit condition and audit logger config into `grpc_core::Rbac`.
Support translation of audit logging options from authz policy to it.
Audit logging options in authz policy looks like:
```json
{
"audit_logging_options": {
"audit_condition": "ON_DENY",
"audit_loggers": [
{
"name": "logger",
"config": {},
"is_optional": false
}
]
}
}
```
which is consistent with what's in the xDS RBAC proto but a little
flattened.
---------
Co-authored-by: rockspore <rockspore@users.noreply.github.com>
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
Add audit condition and audit logger config into `grpc_core::Rbac`.
Support translation of audit logging options from authz policy to it.
Audit logging options in authz policy looks like:
```json
{
"audit_logging_options": {
"audit_condition": "ON_DENY",
"audit_loggers": [
{
"name": "logger",
"config": {},
"is_optional": false
}
]
}
}
```
which is consistent with what's in the xDS RBAC proto but a little
flattened.
---------
Co-authored-by: rockspore <rockspore@users.noreply.github.com>
yijiem
added
release notes: yes
erm-g
removed
the
release notes: yes
yijiem
added
the
release notes: no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add audit condition and audit logger config into
grpc_core::Rbac. Support translation of audit logging options from authz policy to it.Audit logging options in authz policy looks like:
{ "audit_logging_options": { "audit_condition": "ON_DENY", "audit_loggers": [ { "name": "logger", "config": {}, "is_optional": false } ] } }which is consistent with what's in the xDS RBAC proto but a little flattened.