Drop WithContext methods and add context to all methods #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
now that 0.4.0 has been release I wonder if this PR can now be merged @magiconair? |
|
yeah, good point. I'll rebase it and then we'll merge it. |
magiconair
force-pushed
the
issue-553-drop-with-context
branch
from
eea9f6d
to
bb76764
Compare
magiconair
force-pushed
the
issue-553-drop-with-context
branch
from
bb76764
to
4d56b5d
Compare
|
Want to do a final review @CrowdHailer before we merge? |
magiconair
changed the title
magiconair
changed the title
bitomaxsp
reviewed
Aug 14, 2023
|
Too slow from me, but this all looks good. Pleased to see it merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch drops the WithContext() methods and requires that all existing
methods have a context.
NOTE THAT THIS IS A BREAKING CHANGE!!!
Fixes #553