Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(netapp): add config to generate apiv1beta1 #8300

Merged
merged 1 commit into from Jul 20, 2023
Merged

chore(netapp): add config to generate apiv1beta1 #8300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/.OwlBot.yaml
View file
Open in desktop
Expand Up @@ -248,6 +248,7 @@ deep-remove-regex:
- /internal/generated/snippets/monitoring/apiv3/v2/
- /internal/generated/snippets/monitoring/dashboard/apiv1/
- /internal/generated/snippets/monitoring/metricsscope/apiv1/
- /internal/generated/snippets/netapp/apiv1beta1/
- /internal/generated/snippets/networkconnectivity/apiv1/
- /internal/generated/snippets/networkconnectivity/apiv1alpha1/
- /internal/generated/snippets/networkmanagement/apiv1/
Expand Down Expand Up @@ -360,6 +361,7 @@ deep-remove-regex:
- /monitoring/apiv3/v2/
- /monitoring/dashboard/apiv1/
- /monitoring/metricsscope/apiv1/
- /netapp/apiv1beta1/
- /networkconnectivity/apiv1/
- /networkconnectivity/apiv1alpha1/
- /networkmanagement/apiv1/
Expand Down Expand Up @@ -762,6 +764,8 @@ deep-copy-regex:
dest: /
- source: /google/monitoring/metricsscope/v1/cloud.google.com/go
dest: /
- source: /google/cloud/netapp/v1beta1/cloud.google.com/go
dest: /
- source: /google/cloud/networkconnectivity/v1/cloud.google.com/go
dest: /
- source: /google/cloud/networkconnectivity/v1alpha1/cloud.google.com/go
Expand Down
1 change: 1 addition & 0 deletions .release-please-manifest-submodules.json
View file
Open in desktop
Expand Up @@ -73,6 +73,7 @@
"metastore": "1.12.0",
"migrationcenter": "0.1.0",
"monitoring": "1.15.1",
"netapp": "0.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an FYI the post processor is should be smart enough to add the RP files these days:

google-cloud-go/internal/postprocessor/releaseplease.go

Line 122 in e3de5f8

manifest[mod] = "0.0.0"

google-cloud-go/internal/postprocessor/releaseplease.go

Lines 72 to 93 in e3de5f8

f, err := os.OpenFile(filepath.Join(p.googleCloudDir, "release-please-config-yoshi-submodules.json"), os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644)
if err != nil {
return err
}
defer f.Close()
if err := updateConfigFile(f, mods); err != nil {
return err
}
fp := filepath.Join(p.googleCloudDir, ".release-please-manifest-submodules.json")
b, err := os.ReadFile(fp)
if err != nil {
return err
}
f2, err := os.OpenFile(fp, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644)
if err != nil {
return err
}
defer f2.Close()
if err := updateManifestFile(f2, b, mods); err != nil {
return err
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quartzmo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, thank you!

"networkconnectivity": "1.12.1",
"networkmanagement": "1.8.0",
"networksecurity": "0.9.1",
Expand Down
4 changes: 4 additions & 0 deletions internal/postprocessor/config.yaml
View file
Open in desktop
Expand Up @@ -78,6 +78,7 @@ modules:
- metastore
- migrationcenter
- monitoring
- netapp
- networkconnectivity
- networkmanagement
- networksecurity
Expand Down Expand Up @@ -573,6 +574,9 @@ service-configs:
- input-directory: google/cloud/migrationcenter/v1
service-config: migrationcenter_v1.yaml
import-path: cloud.google.com/go/migrationcenter/apiv1
- input-directory: google/cloud/netapp/v1beta1
service-config: netapp_v1beta1.yaml
import-path: cloud.google.com/go/netapp/apiv1beta1
- input-directory: google/cloud/networkconnectivity/v1
service-config: networkconnectivity_v1.yaml
import-path: cloud.google.com/go/networkconnectivity/apiv1
Expand Down
3 changes: 3 additions & 0 deletions release-please-config-yoshi-submodules.json
View file
Open in desktop
Expand Up @@ -225,6 +225,9 @@
"monitoring": {
"component": "monitoring"
},
"netapp": {
"component": "netapp"
},
"networkconnectivity": {
"component": "networkconnectivity"
},
Expand Down