Skip to content

Commit

Permalink
chore(storage): update grpc defaultConnPoolSize (#8297)
Browse files Browse the repository at this point in the history
Updating this in response to internal perf testing results. For launch, we may try to distinguish between direct path and cloud path (C++ does this).
  • Loading branch information
tritone committed Jul 20, 2023
1 parent 4009e8f commit e3de5f8
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions storage/grpc_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,14 @@ import (
)

const (
// defaultConnPoolSize is the default number of connections
// defaultConnPoolSize is the default number of channels
// to initialize in the GAPIC gRPC connection pool. A larger
// connection pool may be necessary for jobs that require
// high throughput and/or leverage many concurrent streams.
// high throughput and/or leverage many concurrent streams
// if not running via DirectPath.
//
// This is only used for the gRPC client.
defaultConnPoolSize = 4
defaultConnPoolSize = 1

// maxPerMessageWriteSize is the maximum amount of content that can be sent
// per WriteObjectRequest message. A buffer reaching this amount will
Expand Down

0 comments on commit e3de5f8

Please sign in to comment.