Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(netapp): add config to generate apiv1beta1 #8300

Merged
merged 1 commit into from Jul 20, 2023

Conversation

quartzmo
Copy link
Member

No description provided.

@quartzmo quartzmo requested a review from a team as a code owner July 20, 2023 19:42
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 20, 2023
@@ -73,6 +73,7 @@
"metastore": "1.12.0",
"migrationcenter": "0.1.0",
"monitoring": "1.15.1",
"netapp": "0.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an FYI the post processor is should be smart enough to add the RP files these days:

f, err := os.OpenFile(filepath.Join(p.googleCloudDir, "release-please-config-yoshi-submodules.json"), os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644)
if err != nil {
return err
}
defer f.Close()
if err := updateConfigFile(f, mods); err != nil {
return err
}
fp := filepath.Join(p.googleCloudDir, ".release-please-manifest-submodules.json")
b, err := os.ReadFile(fp)
if err != nil {
return err
}
f2, err := os.OpenFile(fp, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644)
if err != nil {
return err
}
defer f2.Close()
if err := updateManifestFile(f2, b, mods); err != nil {
return err
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, thank you!

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Jul 20, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4d6247b into googleapis:main Jul 20, 2023
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 20, 2023
@quartzmo quartzmo deleted the owlbot-netapp-v1beta1 branch July 20, 2023 20:12
quartzmo added a commit to quartzmo/google-cloud-go that referenced this pull request Jul 21, 2023
quartzmo added a commit that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants