New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(netapp): add config to generate apiv1beta1 #8300
chore(netapp): add config to generate apiv1beta1 #8300
Conversation
@@ -73,6 +73,7 @@ | |||
"metastore": "1.12.0", | |||
"migrationcenter": "0.1.0", | |||
"monitoring": "1.15.1", | |||
"netapp": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an FYI the post processor is should be smart enough to add the RP files these days:
manifest[mod] = "0.0.0" |
google-cloud-go/internal/postprocessor/releaseplease.go
Lines 72 to 93 in e3de5f8
f, err := os.OpenFile(filepath.Join(p.googleCloudDir, "release-please-config-yoshi-submodules.json"), os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644) | |
if err != nil { | |
return err | |
} | |
defer f.Close() | |
if err := updateConfigFile(f, mods); err != nil { | |
return err | |
} | |
fp := filepath.Join(p.googleCloudDir, ".release-please-manifest-submodules.json") | |
b, err := os.ReadFile(fp) | |
if err != nil { | |
return err | |
} | |
f2, err := os.OpenFile(fp, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644) | |
if err != nil { | |
return err | |
} | |
defer f2.Close() | |
if err := updateManifestFile(f2, b, mods); err != nil { | |
return err | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, thank you!
No description provided.