Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Universe Domain Support for Apiary Clients #19934

Merged
merged 2 commits into from
Mar 19, 2024
Merged

feat: Add Universe Domain Support for Apiary Clients #19934

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3c2c18
chore: Add Universe Domain Support for Apiary Clients
lqiu96 Mar 6, 2024
2674ee9
chore: Bump to v2.4.0 of google-api-java-client
lqiu96 Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion generator/src/googleapis/codegen/languages/java/2.0.0/features.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Java libraries for Google APIs.",
"generator": "java1_15",
"releaseVersion": "2.0.0",
"baseClientLibrary": "2.2.0",
"baseClientLibrary": "2.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be 2.4.0 after the the PR in google-api-client-service is merged and released.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yep. I'll update it to 2.4.0 when it's released. Thanks!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lqiu96 The v2.4.0 is released. Could you please merge this PR? We are waiting on this change to add the TPC support to our Cloud SQL Java Connector. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll proceed with the release today. The new clients should be generated tonight.

"oauthClientLibrary": "1.35.0",
"httpClientLibrary": "1.43.3",
"gsonVersion": "2.10.1",
Expand Down
5 changes: 5 additions & 0 deletions ...leapis/codegen/languages/java/2.0.0/templates/___package___/___api_className___.java.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,5 +247,10 @@ public class {{ api.className }} extends com.google.api.client.googleapis.servic
com.google.api.client.googleapis.services.GoogleClientRequestInitializer googleClientRequestInitializer) {
return (Builder) super.setGoogleClientRequestInitializer(googleClientRequestInitializer);
}

@Override
public Builder setUniverseDomain(String universeDomain) {
return (Builder) super.setUniverseDomain(universeDomain);
}
}
}{% endcollapsenewlines %}