Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Universe Domain Support for Apiary Clients #19934

Merged
merged 2 commits into from Mar 19, 2024

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Mar 6, 2024

No description provided.

@lqiu96 lqiu96 requested a review from blakeli0 March 6, 2024 21:53
@lqiu96 lqiu96 marked this pull request as ready for review March 6, 2024 21:53
@lqiu96 lqiu96 requested a review from a team as a code owner March 6, 2024 21:53
@@ -3,7 +3,7 @@
"description": "Java libraries for Google APIs.",
"generator": "java1_15",
"releaseVersion": "2.0.0",
"baseClientLibrary": "2.2.0",
"baseClientLibrary": "2.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be 2.4.0 after the the PR in google-api-client-service is merged and released.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yep. I'll update it to 2.4.0 when it's released. Thanks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lqiu96 The v2.4.0 is released. Could you please merge this PR? We are waiting on this change to add the TPC support to our Cloud SQL Java Connector. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll proceed with the release today. The new clients should be generated tonight.

@lqiu96 lqiu96 requested a review from blakeli0 March 19, 2024 13:25
@lqiu96 lqiu96 merged commit 114f7fe into main Mar 19, 2024
7 checks passed
@lqiu96 lqiu96 deleted the apiary-universe-domain branch March 19, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants