Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate unit tests from Cloud Build to GitHub Workflows #971

Closed
wants to merge 14 commits into from
Closed

Migrate unit tests from Cloud Build to GitHub Workflows #971

wants to merge 14 commits into from

Commits on Jan 12, 2023

  1. Migrate the unittesting from Cloud Build to GitHub Workflows 

    This way they get run automatically for PRs from external contributors
and do not require manual triggering by repository owners.
    @andrewpollock
    andrewpollock committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    fcd09a9 View commit details
    Browse the repository at this point in the history

  2. Migrate the unittesting from Cloud Build to GitHub Workflows 

    This way they get run automatically for PRs from external contributors
and do not require manual triggering by repository owners.
    @andrewpollock
    andrewpollock committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    fa37d81 View commit details
    Browse the repository at this point in the history

  3. Explicitly install pipenv in the job environments

    @andrewpollock
    andrewpollock committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    43b2311 View commit details
    Browse the repository at this point in the history

  4. Fix typo in pipenv installation command

    @andrewpollock
    andrewpollock committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    47950dd View commit details
    Browse the repository at this point in the history

  5. Try and install the Cloud Datastore Emulator for the tests that need it

    @andrewpollock
    andrewpollock committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    9e3c25e View commit details
    Browse the repository at this point in the history

  6. Improve cosmestics of workflow name

    @andrewpollock
    andrewpollock committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    54d0d4c View commit details
    Browse the repository at this point in the history

  7. Fix installation of Cloud Datastore Emulator

    @andrewpollock
    andrewpollock committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    2d4aada View commit details
    Browse the repository at this point in the history

  8. Support specifying a longer timeout for the datastore emulator startup

    @andrewpollock
    andrewpollock committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    56847a4 View commit details
    Browse the repository at this point in the history

  9. Try doubling the datastore emulator startup timeout 

    to see if that fixes it running in a GitHub Workflow
    @andrewpollock
    andrewpollock committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    9c8750c View commit details
    Browse the repository at this point in the history

  10. Fix formatting

    @andrewpollock
    andrewpollock committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    75f5ee5 View commit details
    Browse the repository at this point in the history

  11. Add some instrumentation to try and understand what's going on

    @andrewpollock
    andrewpollock committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    0677f4a View commit details
    Browse the repository at this point in the history

  12. Install beta component to get cloud-datastore-emulator working

    @andrewpollock
    andrewpollock committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    5b761aa View commit details
    Browse the repository at this point in the history

  13. Remove instrumentation 

    Feeling pretty confident source of problem found and fixed
    @andrewpollock
    andrewpollock committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    54a03a7 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Update .github/workflows/unittest.yaml 

    Co-authored-by: Rex P <106129829+another-rex@users.noreply.github.com>
    @andrewpollock @another-rex
    andrewpollock and another-rex committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    186fa33 View commit details
    Browse the repository at this point in the history