Migrate unit tests from Cloud Build to GitHub Workflows #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way they get run automatically for PRs from external contributors and do not require manual triggering by repository owners.
This way they get run automatically for PRs from external contributors and do not require manual triggering by repository owners.
to see if that fixes it running in a GitHub Workflow
Feeling pretty confident source of problem found and fixed
another-rex
reviewed
Feb 10, 2023
Co-authored-by: Rex P <106129829+another-rex@users.noreply.github.com>
|
Note to self: this is likely to require some credential plumbling like that seen at https://github.com/google/clusterfuzz/blob/ca679d958a209598d30ad4bbe565ff7dd320ea29/src/clusterfuzz/_internal/google_cloud_utils/storage.py#L578 |
another-rex
added a commit
that referenced
this pull request
Feb 13, 2023
Support running workflows when merge queue is switched on. Cloud build doesn't seem to support merge groups yet though, so have to merge #971 before enabling merge queues again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way they get run automatically for PRs from external contributors and do not require manual triggering by repository owners.