Merge from moe writing branch from 061401e8f8d2b201f88f2bfd7509a49b2433685c #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=91642645
…List<String> to be set by a setter whose argument can be given to ImmutableList.copyOf, for example setFoo(Iterable<String>). More generally, if the property type has a method copyOf and the setter parameter is compatible with the copyOf parameter, the setter is valid and its implementation will call copyOf. Also, remove an unnecessary extra copy that was being done for array properties in toBuilder() methods. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=92372232
Its logic to test that GeneratesCodeProcessor had run before RequiresGeneratedCodeProcessor was incorrect. Specifically: 1. Filer.getResource() does not throw for nonexisting files if the location is the output location. 2. The resource to test should have a ".java" extension. 3. The filer fails if you even try to read a resource that exists. Instead, we just keep track of whether the GeneratesCodeProcessor has run on elements and check that explicitly. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=92832468
…oFactories implementing same interface. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=92862023
…e of the project w.r.t. API stability. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=92939163
eamonnmcmanus
added a commit
that referenced
this pull request
May 6, 2015
…8d2b201f88f2bfd7509a49b2433685c Merge from moe writing branch from 061401e
|
Damn, dude, your response time is amazing. :D |
cgruber
deleted the
moe_writing_branch_from_061401e8f8d2b201f88f2bfd7509a49b2433685c
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.