Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump auto-common from 1.0.1 to 1.1 in /value #1129

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 1, 2021

Bumps auto-common from 1.0.1 to 1.1.

Release notes

Sourced from auto-common's releases.

AutoCommon 1.1

  • com.google.auto.common is annotated for null-safety. (9d79ce1)
  • Add String and TypeElement versions of auto-common APIs that currently take in Class. (dec3bf0)
Commits
  • 1cf1f9f Update readme documentation to reflect the AutoValue release.
  • 11be938 [release] Prepare to release AutoValue 1.1.
  • e72ded3 Merge pull request #235 from google/moe_writing_branch_from_061401e8f8d2b201f...
  • acc0ea3 Update the readme for Auto-Common to more accurately reflect the state of the...
  • b1aca4d Fix a bug that causing invalid code generated when using multiple AutoFactori...
  • 2f7ceda Fixed BasicAnnotationProcessorTest.
  • 6634209 In @​AutoValue builders, allow a property whose type is e.g. ImmutableList<Str...
  • d87666c @​AutoValue.Builder API is no longer provisional.
  • 5839c28 Merge pull request #232 from google/release
  • 60a1da1 Merge pull request #231 from google/release_tools
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [auto-common](https://github.com/google/auto) from 1.0.1 to 1.1.
- [Release notes](https://github.com/google/auto/releases)
- [Commits](auto-common-1.0.1...auto-value-1.1)

---
updated-dependencies:
- dependency-name: com.google.auto:auto-common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jul 1, 2021
@google-cla google-cla bot added the cla: yes label Jul 1, 2021
@cpovirk
Copy link
Member

cpovirk commented Jul 8, 2021

For posterity:

Copybara submitted internal copies of this PR, #1127, #1128, and google/compile-testing#259. They've been mirrored out as commits like 4f6f782. However, all those commits were given the description "Internal change," so they didn't contain the usual "Closes #1129" line. They were given that description because the list of commits in the description contains...

e72ded3 Merge pull request #235 from google/moe_writing_branch_from_061401e8f8d2b201f...

...and we have Copybara set up to treat "MOE" as a sensitive word. The motivation for that is to catch broken directives like MOE_strip_line (which should be MOE:strip_line). Ideally, we probably wouldn't treat "MOE" as a sensitive word in the context of a CL/commit description. (I think that that treatment has caused us problems before. To be fair, we've also had problems with the treatment when applied to code, as in google-java-format.)

I'm optimistic that this will not be a frequent issue: Few commits (or other PR descriptions) are likely to mention MOE (or other sensitive words), especially now that most MOE users have migrated to Copybara. If it keeps coming up, we could probably tweak our sensitive-word detection (at least for changes that are being automatically imported by Copybara) and/or our translation of PR descriptions into CL descriptions (since the Dependabot ones are super-long, anyway).

Plus, in the case of Dependabot, Dependabot will eventually notice that its changes have already been made, and it will close the PRs. I'll just do that now, though, since I'm going to the trouble to post this comment.

@cpovirk cpovirk closed this Jul 8, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 8, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants