Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from moe writing branch from 061401e8f8d2b201f88f2bfd7509a49b2433685c #235

Commits on May 6, 2015

  1. @AutoValue.Builder API is no longer provisional.

    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=91642645
    eamonnmcmanus authored and cgruber committed May 6, 2015
    Configuration menu
    Copy the full SHA
    d87666c View commit details
    Browse the repository at this point in the history
  2. In @autovalue builders, allow a property whose type is e.g. Immutable…

    …List<String> to be set by a setter whose argument can be given to ImmutableList.copyOf, for example setFoo(Iterable<String>). More generally, if the property type has a method copyOf and the setter parameter is compatible with the copyOf parameter, the setter is valid and its implementation will call copyOf.
    
    Also, remove an unnecessary extra copy that was being done for array properties in toBuilder() methods.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=92372232
    eamonnmcmanus authored and cgruber committed May 6, 2015
    Configuration menu
    Copy the full SHA
    6634209 View commit details
    Browse the repository at this point in the history
  3. Fixed BasicAnnotationProcessorTest.

    Its logic to test that GeneratesCodeProcessor had run before RequiresGeneratedCodeProcessor was incorrect. Specifically:
    
    1. Filer.getResource() does not throw for nonexisting files if the location is the output location.
    
    2. The resource to test should have a ".java" extension.
    
    3. The filer fails if you even try to read a resource that exists.
    
    Instead, we just keep track of whether the GeneratesCodeProcessor has run on elements and check that explicitly.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=92832468
    netdpb authored and cgruber committed May 6, 2015
    Configuration menu
    Copy the full SHA
    2f7ceda View commit details
    Browse the repository at this point in the history
  4. Fix a bug that causing invalid code generated when using multiple Aut…

    …oFactories implementing same interface.
    
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=92862023
    Oleksandr Gumen authored and cgruber committed May 6, 2015
    Configuration menu
    Copy the full SHA
    b1aca4d View commit details
    Browse the repository at this point in the history
  5. Update the readme for Auto-Common to more accurately reflect the stat…

    …e of the project w.r.t. API stability.
    
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=92939163
    cgruber committed May 6, 2015
    Configuration menu
    Copy the full SHA
    acc0ea3 View commit details
    Browse the repository at this point in the history