Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new configuration Parameter #1665

Merged
merged 20 commits into from May 1, 2023
Merged

Add new configuration Parameter #1665

merged 20 commits into from May 1, 2023

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented May 1, 2023 •
edited

Identical to #1590, but merged with a recent version of main to avoid conflicts.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

tgrall and others added 19 commits March 18, 2023 13:40
@tgrall
- Add new configuration Parameter
ee44252 
- Write test to check it is read from configuration
- Update documentation
@tgrall
update changelog
94786b3
@tgrall
fix linter issues
2f14134
@tgrall
Update README.md - typo
f81f527
@tgrall
Update README.md
f1fb80a
@tgrall
fix CI failure - check js
34231cf
@tgrall
rename new parameter from configuration to config
fe4a785
@tgrall
Merge branch 'main' into issue-1589-config-param
18f1345
@tgrall @henrymercer
Accept change in PR
696504d 
Co-authored-by: Henry Mercer <henry.mercer@me.com>
@tgrall @henrymercer
Update init/action.yml : PR review
a9fb7d9 
Co-authored-by: Henry Mercer <henry.mercer@me.com>
@tgrall @henrymercer
Update README.md : during PR Review
d2950c1 
Co-authored-by: Henry Mercer <henry.mercer@me.com>
@tgrall @henrymercer
Update README.md : during PR Review
c9f360d 
Co-authored-by: Henry Mercer <henry.mercer@me.com>
@tgrall @henrymercer
Update CHANGELOG.md : during PR Review
0b75f47 
Co-authored-by: Henry Mercer <henry.mercer@me.com>
@tgrall
resolve comments from @henrymercer
b4e6f81
@tgrall
remove the documentation about workflow parameters
fc374f5
@tgrall
fix after review from @henrymercer
f398a65
@tgrall
remove space from json string
7b876ae
@tgrall
add test with config file and input together
47cec7a
@aeisenberg
Merge remote-tracking branch 'upstream/main' into issue-1589-config-p…
824d18c 
…aram
@aeisenberg aeisenberg requested a review from a team as a code owner May 1, 2023 15:43
@aeisenberg aeisenberg changed the title Aeisenberg/config param Add new configuration Parameter May 1, 2023
@aeisenberg aeisenberg mentioned this pull request May 1, 2023
Closed
4 tasks
aeisenberg
aeisenberg commented May 1, 2023
View reviewed changes
Copy link
Contributor Author

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update changelog entry.

CHANGELOG.md Outdated Show resolved Hide resolved
@aeisenberg aeisenberg merged commit d2f6dfd into main May 1, 2023
325 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/config-param branch May 1, 2023 17:26
@github-actions github-actions bot mentioned this pull request May 4, 2023
Merged
6 tasks
@jeffwidman jeffwidman mentioned this pull request May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cklin cklin cklin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aeisenberg @cklin @tgrall