CodeQL: ignore purposefully invalid ruby files #7126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
commented
Apr 20, 2023
4 tasks
jeffwidman
force-pushed
the
codeql-ignore-purposefully-invalid-ruby-files
branch
2 times, most recently
from
57cb324
to
246a15c
Compare
[2023-05-12 08:45:39] [build-stdout] [2023-05-12 08:45:39] [build-stdout] WARN /home/runner/work/dependabot-core/dependabot-core/common/spec/dependabot/dependency_file_spec.rb:81: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.
[2023-05-12 08:45:39] [build-stdout] [2023-05-12 08:45:39] [build-stdout] WARN /home/runner/work/dependabot-core/dependabot-core/common/spec/dependabot/dependency_file_spec.rb:83: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.🤔 hmm, these look okay to me: dependabot-core/common/spec/dependabot/dependency_file_spec.rb Lines 81 to 83 in f103d05 |
CodeQL is complaining that these two files are unparsable Ruby: ``` [2023-04-20 07:34:33] [build-stdout] [2023-04-20 07:34:33] [build-stdout] WARN /home/runner/work/dependabot-core/dependabot-core/bundler/spec/fixtures/projects/bundler1/invalid_ruby/Gemfile:2: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. [2023-04-20 07:34:33] [build-stdout] [2023-04-20 07:34:33] [build-stdout] WARN /home/runner/work/dependabot-core/dependabot-core/bundler/spec/fixtures/projects/bundler2/invalid_ruby/Gemfile:2: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. ``` These two files are test specs and intentionally unparsable, so ignoring them. Docs on configuring ignores are here: * https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/customizing-code-scanning#specifying-directories-to-scan * https://github.com/github/codeql-action#configuration-via-config-input
jeffwidman
force-pushed
the
codeql-ignore-purposefully-invalid-ruby-files
branch
from
246a15c
to
3a74ac1
Compare
deivid-rodriguez
approved these changes
May 12, 2023
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
CodeQL is complaining that these two files are unparsable Ruby: ``` [2023-04-20 07:34:33] [build-stdout] [2023-04-20 07:34:33] [build-stdout] WARN /home/runner/work/dependabot-core/dependabot-core/bundler/spec/fixtures/projects/bundler1/invalid_ruby/Gemfile:2: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. [2023-04-20 07:34:33] [build-stdout] [2023-04-20 07:34:33] [build-stdout] WARN /home/runner/work/dependabot-core/dependabot-core/bundler/spec/fixtures/projects/bundler2/invalid_ruby/Gemfile:2: A parse error occurred. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis. ``` These two files are test specs and intentionally unparsable, so ignoring them. Docs on configuring ignores are here: * https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/customizing-code-scanning#specifying-directories-to-scan * https://github.com/github/codeql-action#configuration-via-config-input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeQL is complaining that these two files are unparsable Ruby:
These two files are test specs and intentionally unparsable, so ignoring them.
Docs on configuring ignores are here: