openapi3: fix abort logic of validation for schemas with anyOf, allOf, oneOf #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AmadeusK525 @fenollp Checked with ourselves. Problem solved. Thank you! Waiting for the release. |
fenollp
requested changes
Jan 11, 2024
|
@AmadeusK525 Hey please merge profusion#1 :) |
|
Hey sorry @fenollp, missed your ping, but I included your changes in the commits, thanks! Good to know this issue was resolved! cc: @micronull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only abort further validation if xOf validations were successful AND the value is
nil(this means that the xOf was nullable for a fact). Otherwise, continue validating against the parent schemaRelated Issues