openapi3: fix schema validation for anyOf, allOf, oneOf operations
#850
+73
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be safely assumed that the value is valid if the 'XOF' operations were successful
Old validation immediately exited if the value passed was nil and the schema wasn't nullable. This isn't correct, though, as a schema can have a nullable type in its XOF operations, and that should result in correct validation if the input is 'nil'
fenollp
changed the title
XOF operationsanyOf, allOf, oneOf operations
|
Thanks for this! |
|
@AmadeusK525 Your edits broke our tests. I can't tell you exactly why yet. Something to do with the if err, run = schema.visitXOFOperations(settings, value); err != nil || !run {
return
} |
|
You have all the tests run so the execution process doesn't get to validation. |
|
@micronull could you provide an example of a broken test, please? |
|
@AmadeusK525 Yes. I have plans for a separate issue. |
|
Thank you @micronull, this was a mistake on my part for misunderstanding OpenAPI, it's a super easy fix, I'll open up a PR right now |
|
@micronull Check it out #892 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schemas with
XOFchildren that allowed for nullable values had their validation broken, as thenullcheck happened before theXOFcheck and would fail immediately, without checking ifXOFallowed for such nullability