Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ambiguous_glob_reexports rustc lint #2301

Merged
merged 2 commits into from Mar 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ethers-core/src/types/chain.rs
Expand Up @@ -621,7 +621,7 @@ mod tests {
fn serde_to_string_match() {
for chain in Chain::iter() {
let chain_serde = serde_json::to_string(&chain).unwrap();
let chain_string = format!("\"{}\"", chain.to_string());
let chain_string = format!("\"{}\"", chain);
assert_eq!(chain_serde, chain_string);
}
}
Expand Down
2 changes: 1 addition & 1 deletion ethers-etherscan/src/lib.rs
Expand Up @@ -24,7 +24,7 @@ pub mod contract;
pub mod errors;
pub mod gas;
pub mod source_tree;
pub mod transaction;
mod transaction;
pub mod utils;
pub mod verify;

Expand Down
3 changes: 2 additions & 1 deletion ethers/src/lib.rs
Expand Up @@ -106,8 +106,9 @@ pub use ethers_core::{abi, types, utils};

/// Easy imports of frequently used type definitions and traits.
#[doc(hidden)]
#[allow(ambiguous_glob_reexports)]
pub mod prelude {
pub use super::addressbook::*;
pub use super::addressbook::contract;

pub use super::contract::*;

Expand Down