Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ambiguous_glob_reexports rustc lint #2301

Merged
merged 2 commits into from Mar 27, 2023

Conversation

DaniPopes
Copy link
Collaborator

Motivation

new rustc lint dropped, warn level by default

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes
Copy link
Collaborator Author

eip712 / live tests are changed in #2279, not going to change it here

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prestwich prestwich merged commit 27f895f into gakonst:master Mar 27, 2023
14 of 16 checks passed
@DaniPopes DaniPopes deleted the chore/lints branch March 27, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants