Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kqueue: fix removing a directory #537

Merged
merged 3 commits into from
Nov 16, 2022
Merged

kqueue: fix removing a directory #537

merged 3 commits into from
Nov 16, 2022

Commits on Nov 16, 2022

  1. kqueue: fix removing a directory 

    Fix regression from #526, which would sometimes fail with something
along the lines of:

    --- FAIL: TestWatchRm/remove_watched_directory (1.30s)
        helpers_test.go:384: fsnotify.sendDirectoryChangeEvents: open /tmp/TestWatchRmremove_watched_directory2055111636/001: no such file or directory
        fsnotify_test.go:750:
            have:
            	REMOVE               "/a"
            	REMOVE               "/b"
            	REMOVE               "/c"
            	REMOVE               "/d"
            	REMOVE               "/e"
            	REMOVE               "/f"
            	REMOVE               "/g"
            want:
            	REMOVE               "/"
            	REMOVE               "/a"
            	REMOVE               "/b"
            	REMOVE               "/c"
            	REMOVE               "/d"
            	REMOVE               "/e"
            	REMOVE               "/f"
            	REMOVE               "/g"
            	REMOVE               "/h"
            	REMOVE               "/i"
            	REMOVE               "/j"

We can just always ignore a directory no longer existing; kqueue should
still send the correct events.

Also noticed the error on sendFileCreatedEventIfNew() wasn't really
being sent properly, so deal with that as well.
    @arp242
    arp242 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    2b69a9c View commit details
    Browse the repository at this point in the history

  2. Fix BSD CI ... hopefully

    @arp242
    arp242 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    c8ed0c8 View commit details
    Browse the repository at this point in the history

  3. Run FreeBSD CI on Cirrus

    @arp242
    arp242 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    5f1f785 View commit details
    Browse the repository at this point in the history