kqueue: fix removing a directory #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regression from #526, which would sometimes fail with something along the lines of: --- FAIL: TestWatchRm/remove_watched_directory (1.30s) helpers_test.go:384: fsnotify.sendDirectoryChangeEvents: open /tmp/TestWatchRmremove_watched_directory2055111636/001: no such file or directory fsnotify_test.go:750: have: REMOVE "/a" REMOVE "/b" REMOVE "/c" REMOVE "/d" REMOVE "/e" REMOVE "/f" REMOVE "/g" want: REMOVE "/" REMOVE "/a" REMOVE "/b" REMOVE "/c" REMOVE "/d" REMOVE "/e" REMOVE "/f" REMOVE "/g" REMOVE "/h" REMOVE "/i" REMOVE "/j" We can just always ignore a directory no longer existing; kqueue should still send the correct events. Also noticed the error on sendFileCreatedEventIfNew() wasn't really being sent properly, so deal with that as well.
arp242
force-pushed
the
fix-526
branch
2 times, most recently
from
b440d19
to
771c4ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression from #526, which would sometimes fail with something along the lines of:
We can just always ignore a directory no longer existing; kqueue should still send the correct events.